mirror of
https://github.com/discourse/discourse.git
synced 2025-05-22 07:53:49 +08:00
FEATURE: Added 'select +below' and 'select +all replies' options to selecting posts
This commit is contained in:
Régis Hanol
@ -1,126 +1,318 @@
|
||||
import { mapRoutes } from 'discourse/mapping-router';
|
||||
import AppEvents from "discourse/lib/app-events";
|
||||
import Topic from "discourse/models/topic";
|
||||
|
||||
moduleFor('controller:topic', 'controller:topic', {
|
||||
needs: ['controller:modal', 'controller:composer', 'controller:application'],
|
||||
moduleFor("controller:topic", "controller:topic", {
|
||||
needs: ["controller:composer", "controller:application"],
|
||||
beforeEach() {
|
||||
this.registry.register('router:main', mapRoutes());
|
||||
},
|
||||
this.registry.register("app-events:main", AppEvents.create(), { instantiate: false });
|
||||
this.registry.injection("controller", "appEvents", "app-events:main");
|
||||
}
|
||||
});
|
||||
|
||||
import Topic from 'discourse/models/topic';
|
||||
import AppEvents from 'discourse/lib/app-events';
|
||||
QUnit.test("editTopic", function(assert) {
|
||||
const model = Topic.create();
|
||||
const controller = this.subject({ model });
|
||||
|
||||
var buildTopic = function() {
|
||||
return Topic.create({
|
||||
title: "Qunit Test Topic",
|
||||
participants: [
|
||||
{id: 1234,
|
||||
post_count: 4,
|
||||
username: "eviltrout"}
|
||||
]
|
||||
});
|
||||
};
|
||||
assert.not(controller.get("editingTopic"), "we are not editing by default");
|
||||
|
||||
controller.set("model.details.can_edit", false);
|
||||
controller.send("editTopic");
|
||||
|
||||
QUnit.test("editingMode", function(assert) {
|
||||
var topic = buildTopic(),
|
||||
topicController = this.subject({model: topic});
|
||||
assert.not(controller.get("editingTopic"), "calling editTopic doesn't enable editing unless the user can edit");
|
||||
|
||||
assert.ok(!topicController.get('editingTopic'), "we are not editing by default");
|
||||
controller.set("model.details.can_edit", true);
|
||||
controller.send("editTopic");
|
||||
|
||||
topicController.set('model.details.can_edit', false);
|
||||
topicController.send('editTopic');
|
||||
assert.ok(!topicController.get('editingTopic'), "calling editTopic doesn't enable editing unless the user can edit");
|
||||
assert.ok(controller.get("editingTopic"), "calling editTopic enables editing if the user can edit");
|
||||
assert.equal(controller.get("buffered.title"), model.get("title"));
|
||||
assert.equal(controller.get("buffered.category_id"), model.get("category_id"));
|
||||
|
||||
topicController.set('model.details.can_edit', true);
|
||||
topicController.send('editTopic');
|
||||
assert.ok(topicController.get('editingTopic'), "calling editTopic enables editing if the user can edit");
|
||||
assert.equal(topicController.get('buffered.title'), topic.get('title'));
|
||||
assert.equal(topicController.get('buffered.category_id'), topic.get('category_id'));
|
||||
controller.send("cancelEditingTopic");
|
||||
|
||||
topicController.send('cancelEditingTopic');
|
||||
assert.ok(!topicController.get('editingTopic'), "cancelling edit mode reverts the property value");
|
||||
assert.not(controller.get("editingTopic"), "cancelling edit mode reverts the property value");
|
||||
});
|
||||
|
||||
QUnit.test("toggledSelectedPost", function(assert) {
|
||||
var tc = this.subject({ model: buildTopic() }),
|
||||
post = Discourse.Post.create({id: 123, post_number: 2}),
|
||||
postStream = tc.get('model.postStream');
|
||||
QUnit.test("toggleMultiSelect", function(assert) {
|
||||
const model = Topic.create();
|
||||
const controller = this.subject({ model });
|
||||
|
||||
postStream.appendPost(post);
|
||||
postStream.appendPost(Discourse.Post.create({id: 124, post_number: 3}));
|
||||
assert.not(controller.get("multiSelect"), "multi selection mode is disabled by default");
|
||||
|
||||
assert.blank(tc.get('selectedPosts'), "there are no selected posts by default");
|
||||
assert.equal(tc.get('selectedPostsCount'), 0, "there is a selected post count of 0");
|
||||
assert.ok(!tc.postSelected(post), "the post is not selected by default");
|
||||
controller.get("selectedPostIds").pushObject(1);
|
||||
assert.equal(controller.get("selectedPostIds.length"), 1);
|
||||
|
||||
tc.send('toggledSelectedPost', post);
|
||||
assert.present(tc.get('selectedPosts'), "there is a selectedPosts collection");
|
||||
assert.equal(tc.get('selectedPostsCount'), 1, "there is a selected post now");
|
||||
assert.ok(tc.postSelected(post), "the post is now selected");
|
||||
controller.send("toggleMultiSelect");
|
||||
|
||||
tc.send('toggledSelectedPost', post);
|
||||
assert.ok(!tc.postSelected(post), "the post is no longer selected");
|
||||
assert.ok(controller.get("multiSelect"), "calling 'toggleMultiSelect' once enables multi selection mode");
|
||||
assert.equal(controller.get("selectedPostIds.length"), 0, "toggling 'multiSelect' clears 'selectedPostIds'");
|
||||
|
||||
controller.get("selectedPostIds").pushObject(2);
|
||||
assert.equal(controller.get("selectedPostIds.length"), 1);
|
||||
|
||||
controller.send("toggleMultiSelect");
|
||||
|
||||
assert.not(controller.get("multiSelect"), "calling 'toggleMultiSelect' twice disables multi selection mode");
|
||||
assert.equal(controller.get("selectedPostIds.length"), 0, "toggling 'multiSelect' clears 'selectedPostIds'");
|
||||
});
|
||||
|
||||
QUnit.test("selectAll", function(assert) {
|
||||
var tc = this.subject({model: buildTopic(), appEvents: AppEvents.create()}),
|
||||
post = Discourse.Post.create({id: 123, post_number: 2}),
|
||||
postStream = tc.get('model.postStream');
|
||||
QUnit.test("selectedPosts", function(assert) {
|
||||
const postStream = { posts: [{ id: 1 }, { id: 2 }, { id: 3 }] };
|
||||
const model = Topic.create({ postStream });
|
||||
const controller = this.subject({ model });
|
||||
|
||||
postStream.appendPost(post);
|
||||
|
||||
assert.ok(!tc.postSelected(post), "the post is not selected by default");
|
||||
tc.send('selectAll');
|
||||
assert.ok(tc.postSelected(post), "the post is now selected");
|
||||
assert.ok(tc.get('allPostsSelected'), "all posts are selected");
|
||||
tc.send('deselectAll');
|
||||
assert.ok(!tc.postSelected(post), "the post is deselected again");
|
||||
assert.ok(!tc.get('allPostsSelected'), "all posts are not selected");
|
||||
controller.set("selectedPostIds", [1, 2, 42]);
|
||||
|
||||
assert.equal(controller.get("selectedPosts.length"), 2, "selectedPosts only contains already loaded posts");
|
||||
assert.not(controller.get("selectedPosts").some(p => p === undefined), "selectedPosts only contains valid post objects");
|
||||
});
|
||||
|
||||
QUnit.test("Automating setting of allPostsSelected", function(assert) {
|
||||
var topic = buildTopic(),
|
||||
tc = this.subject({model: topic}),
|
||||
post = Discourse.Post.create({id: 123, post_number: 2}),
|
||||
postStream = tc.get('model.postStream');
|
||||
QUnit.test("selectedAllPosts", function(assert) {
|
||||
const postStream = { stream: [1, 2, 3] };
|
||||
const model = Topic.create({ postStream });
|
||||
const controller = this.subject({ model });
|
||||
|
||||
topic.set('posts_count', 1);
|
||||
postStream.appendPost(post);
|
||||
assert.ok(!tc.get('allPostsSelected'), "all posts are not selected by default");
|
||||
controller.set("selectedPostIds", [1, 2]);
|
||||
|
||||
tc.send('toggledSelectedPost', post);
|
||||
assert.ok(tc.get('allPostsSelected'), "all posts are selected if we select the only post");
|
||||
assert.not(controller.get("selectedAllPosts"), "not all posts are selected");
|
||||
|
||||
tc.send('toggledSelectedPost', post);
|
||||
assert.ok(!tc.get('allPostsSelected'), "the posts are no longer automatically selected");
|
||||
controller.get("selectedPostIds").pushObject(3);
|
||||
|
||||
assert.ok(controller.get("selectedAllPosts"), "all posts are selected");
|
||||
|
||||
controller.get("selectedPostIds").pushObject(42);
|
||||
|
||||
assert.ok(controller.get("selectedAllPosts"), "all posts (including filtered posts) are selected");
|
||||
});
|
||||
|
||||
QUnit.test("Select Replies when present", function(assert) {
|
||||
var topic = buildTopic(),
|
||||
tc = this.subject({ model: topic, appEvents: AppEvents.create() }),
|
||||
p1 = Discourse.Post.create({id: 1, post_number: 1, reply_count: 1}),
|
||||
p2 = Discourse.Post.create({id: 2, post_number: 2}),
|
||||
p3 = Discourse.Post.create({id: 2, post_number: 3, reply_to_post_number: 1});
|
||||
QUnit.test("selectedPostsUsername", function(assert) {
|
||||
const postStream = {
|
||||
posts: [
|
||||
{ id: 1, username: "gary" },
|
||||
{ id: 2, username: "gary" },
|
||||
{ id: 3, username: "lili" },
|
||||
],
|
||||
stream: [1, 2, 3]
|
||||
};
|
||||
|
||||
assert.ok(!tc.postSelected(p3), "replies are not selected by default");
|
||||
tc.send('toggledSelectedPostReplies', p1);
|
||||
assert.ok(tc.postSelected(p1), "it selects the post");
|
||||
assert.ok(!tc.postSelected(p2), "it doesn't select a post that's not a reply");
|
||||
assert.ok(tc.postSelected(p3), "it selects a post that is a reply");
|
||||
assert.equal(tc.get('selectedPostsCount'), 2, "it has a selected posts count of two");
|
||||
const model = Topic.create({ postStream });
|
||||
const controller = this.subject({ model });
|
||||
const selectedPostIds = controller.get("selectedPostIds");
|
||||
|
||||
// If we deselected the post whose replies are selected...
|
||||
tc.send('toggledSelectedPost', p1);
|
||||
assert.ok(!tc.postSelected(p1), "it deselects the post");
|
||||
assert.ok(!tc.postSelected(p3), "it deselects the replies too");
|
||||
assert.equal(controller.get("selectedPostsUsername"), undefined, "no username when no selected posts");
|
||||
|
||||
// If we deselect a reply, it should deselect the parent's replies selected attribute. Weird but what else would make sense?
|
||||
tc.send('toggledSelectedPostReplies', p1);
|
||||
tc.send('toggledSelectedPost', p3);
|
||||
assert.ok(tc.postSelected(p1), "the post stays selected");
|
||||
assert.ok(!tc.postSelected(p3), "it deselects the replies too");
|
||||
selectedPostIds.pushObject(1);
|
||||
|
||||
assert.equal(controller.get("selectedPostsUsername"), "gary", "username of the selected posts");
|
||||
|
||||
selectedPostIds.pushObject(2);
|
||||
|
||||
assert.equal(controller.get("selectedPostsUsername"), "gary", "username of all the selected posts when same user");
|
||||
|
||||
selectedPostIds.pushObject(3);
|
||||
|
||||
assert.equal(controller.get("selectedPostsUsername"), undefined, "no username when more than 1 user");
|
||||
|
||||
selectedPostIds.replace(2, 1, [42]);
|
||||
|
||||
assert.equal(controller.get("selectedPostsUsername"), undefined, "no username when not already loaded posts are selected");
|
||||
});
|
||||
|
||||
QUnit.test("showSelectedPostsAtBottom", function(assert) {
|
||||
const site = Ember.Object.create({ mobileView: false });
|
||||
const model = Topic.create({ posts_count: 3 });
|
||||
const controller = this.subject({ model, site });
|
||||
|
||||
assert.not(controller.get("showSelectedPostsAtBottom"), "false on desktop")
|
||||
|
||||
site.set("mobileView", true);
|
||||
|
||||
assert.not(controller.get("showSelectedPostsAtBottom"), "requires at least 3 posts on mobile");
|
||||
|
||||
model.set("posts_count", 4);
|
||||
|
||||
assert.ok(controller.get("showSelectedPostsAtBottom"), "true when mobile and more than 3 posts");
|
||||
});
|
||||
|
||||
QUnit.test("canDeleteSelected", function(assert) {
|
||||
const postStream = {
|
||||
posts: [
|
||||
{ id: 1, can_delete: false },
|
||||
{ id: 2, can_delete: true },
|
||||
{ id: 3, can_delete: true }
|
||||
],
|
||||
stream: [1, 2, 3]
|
||||
};
|
||||
|
||||
const model = Topic.create({ postStream });
|
||||
const controller = this.subject({ model });
|
||||
const selectedPostIds = controller.get("selectedPostIds");
|
||||
|
||||
assert.not(controller.get("canDeleteSelected"), "false when no posts are selected");
|
||||
|
||||
selectedPostIds.pushObject(1);
|
||||
|
||||
assert.not(controller.get("canDeleteSelected"), "false when can't delete one of the selected posts");
|
||||
|
||||
selectedPostIds.replace(0, 1, [2, 3]);
|
||||
|
||||
assert.ok(controller.get("canDeleteSelected"), "true when all selected posts can be deleted");
|
||||
|
||||
selectedPostIds.pushObject(1);
|
||||
|
||||
assert.ok(controller.get("canDeleteSelected"), "true when all posts are selected");
|
||||
});
|
||||
|
||||
QUnit.test("Can split/merge topic", function(assert) {
|
||||
const postStream = {
|
||||
posts: [{ id: 1 }, { id: 2 }],
|
||||
stream: [1, 2]
|
||||
};
|
||||
|
||||
const model = Topic.create({ postStream, details: { can_move_posts: false } });
|
||||
const controller = this.subject({ model });
|
||||
const selectedPostIds = controller.get("selectedPostIds");
|
||||
|
||||
assert.not(controller.get("canSplitTopic"), "can't split topic when no posts are selected");
|
||||
assert.not(controller.get("canMergeTopic"), "can't merge topic when no posts are selected");
|
||||
|
||||
selectedPostIds.pushObject(1);
|
||||
|
||||
assert.not(controller.get("canSplitTopic"), "can't split topic when can't move posts");
|
||||
assert.not(controller.get("canMergeTopic"), "can't merge topic when can't move posts");
|
||||
|
||||
model.set("details.can_move_posts", true);
|
||||
|
||||
assert.ok(controller.get("canSplitTopic"), "can split topic");
|
||||
assert.ok(controller.get("canMergeTopic"), "can merge topic");
|
||||
|
||||
selectedPostIds.pushObject(2);
|
||||
|
||||
assert.not(controller.get("canSplitTopic"), "can't split topic when all posts are selected");
|
||||
assert.ok(controller.get("canMergeTopic"), "can merge topic when all posts are selected");
|
||||
});
|
||||
|
||||
QUnit.test("canChangeOwner", function(assert) {
|
||||
const currentUser = Discourse.User.create({ admin: false });
|
||||
this.registry.register("current-user:main", currentUser, { instantiate: false });
|
||||
this.registry.injection("controller", "currentUser", "current-user:main");
|
||||
|
||||
const postStream = {
|
||||
posts: [
|
||||
{ id: 1, username: "gary" },
|
||||
{ id: 2, username: "lili" },
|
||||
],
|
||||
stream: [1, 2]
|
||||
};
|
||||
|
||||
const model = Topic.create({ postStream, currentUser: { admin: false }});
|
||||
const controller = this.subject({ model });
|
||||
const selectedPostIds = controller.get("selectedPostIds");
|
||||
|
||||
assert.not(controller.get("canChangeOwner"), "false when no posts are selected");
|
||||
|
||||
selectedPostIds.pushObject(1);
|
||||
|
||||
assert.not(controller.get("canChangeOwner"), "false when not admin");
|
||||
|
||||
currentUser.set("admin", true);
|
||||
|
||||
assert.ok(controller.get("canChangeOwner"), "true when admin and one post is selected");
|
||||
|
||||
selectedPostIds.pushObject(2);
|
||||
|
||||
assert.not(controller.get("canChangeOwner"), "false when admin but more than 1 user");
|
||||
});
|
||||
|
||||
QUnit.test("canMergePosts", function(assert) {
|
||||
const postStream = {
|
||||
posts: [
|
||||
{ id: 1, username: "gary", can_delete: true },
|
||||
{ id: 2, username: "lili", can_delete: true },
|
||||
{ id: 3, username: "gary", can_delete: false },
|
||||
{ id: 4, username: "gary", can_delete: true },
|
||||
],
|
||||
stream: [1, 2, 3]
|
||||
};
|
||||
|
||||
const model = Topic.create({ postStream });
|
||||
const controller = this.subject({ model });
|
||||
const selectedPostIds = controller.get("selectedPostIds");
|
||||
|
||||
assert.not(controller.get("canMergePosts"), "false when no posts are selected");
|
||||
|
||||
selectedPostIds.pushObject(1);
|
||||
|
||||
assert.not(controller.get("canMergePosts"), "false when only one post is selected");
|
||||
|
||||
selectedPostIds.pushObject(2);
|
||||
|
||||
assert.not(controller.get("canMergePosts"), "false when selected posts are from different users");
|
||||
|
||||
selectedPostIds.replace(1, 1, [3]);
|
||||
|
||||
assert.not(controller.get("canMergePosts"), "false when selected posts can't be deleted");
|
||||
|
||||
selectedPostIds.replace(1, 1, [4]);
|
||||
|
||||
assert.ok(controller.get("canMergePosts"), "true when all selected posts are deletable and by the same user");
|
||||
});
|
||||
|
||||
QUnit.test("Select/deselect all", function(assert) {
|
||||
const postStream = { stream: [1, 2, 3] };
|
||||
const model = Topic.create({ postStream });
|
||||
const controller = this.subject({ model });
|
||||
|
||||
assert.equal(controller.get("selectedPostsCount"), 0, "no posts selected by default");
|
||||
|
||||
controller.send("selectAll");
|
||||
|
||||
assert.equal(controller.get("selectedPostsCount"), postStream.stream.length, "calling 'selectAll' selects all posts");
|
||||
|
||||
controller.send("deselectAll");
|
||||
|
||||
assert.equal(controller.get("selectedPostsCount"), 0, "calling 'deselectAll' deselects all posts");
|
||||
});
|
||||
|
||||
QUnit.test("togglePostSelection", function(assert) {
|
||||
const controller = this.subject();
|
||||
const selectedPostIds = controller.get("selectedPostIds");
|
||||
|
||||
assert.equal(selectedPostIds[0], undefined, "no posts selected by default");
|
||||
|
||||
controller.send("togglePostSelection", { id: 1 });
|
||||
|
||||
assert.equal(selectedPostIds[0], 1, "adds the selected post id if not already selected");
|
||||
|
||||
controller.send("togglePostSelection", { id: 1 });
|
||||
|
||||
assert.equal(selectedPostIds[0], undefined, "removes the selected post id if already selected");
|
||||
});
|
||||
|
||||
// QUnit.test("selectReplies", function(assert) {
|
||||
// const controller = this.subject();
|
||||
// const selectedPostIds = controller.get("selectedPostIds");
|
||||
//
|
||||
// assert.equal(selectedPostIds[0], undefined, "no posts selected by default");
|
||||
//
|
||||
// controller.send("selectReplies", { id: 42 });
|
||||
//
|
||||
// assert.equal(selectedPostIds[0], 42, "selected post #42");
|
||||
// assert.equal(selectedPostIds[1], 45, "selected post #45");
|
||||
// assert.equal(selectedPostIds[2], 100, "selected post #100");
|
||||
// });
|
||||
|
||||
QUnit.test("selectBelow", function(assert) {
|
||||
const postStream = { stream: [1, 2, 3, 4, 5] };
|
||||
const model = Topic.create({ postStream });
|
||||
const controller = this.subject({ model });
|
||||
const selectedPostIds = controller.get("selectedPostIds");
|
||||
|
||||
assert.equal(selectedPostIds[0], undefined, "no posts selected by default");
|
||||
|
||||
controller.send("selectBelow", { id: 3 });
|
||||
|
||||
assert.equal(selectedPostIds[0], 3, "selected post #3");
|
||||
assert.equal(selectedPostIds[1], 4, "also selected 1st post below post #3");
|
||||
assert.equal(selectedPostIds[2], 5, "also selected 2nd post below post #3");
|
||||
});
|
||||
|
||||
|
||||
Reference in New Issue
Block a user