github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-04 21:59:34 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: Tweak styling for the new /about page (#28367)

Browse Source 
Various tweaks the new /about page. Main change is to make it display 3 columns of users instead of 2 when there's enough space.
This commit is contained in:
Osama Sayegh
2024-08-14 14:57:35 +03:00
committed by GitHub
parent 1ffb0462c1
commit 1bcb5c4e21
4 changed files with 27 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
spec/system/about_page_spec.rb
View File

@ -182,9 +182,9 @@ describe "About page", type: :system do
describe "our admins section" do
before { User.update_all(last_seen_at: 1.month.ago) }
fab!(:admins) { Fabricate.times(12, :admin) }
fab!(:admins) { Fabricate.times(14, :admin) }
it "displays only the 10 most recently seen admins when there are more than 10 admins" do
it "displays only the 12 most recently seen admins when there are more than 12 admins" do
admins[0].update!(last_seen_at: 4.minutes.ago)
admins[1].update!(last_seen_at: 1.minutes.ago)
admins[2].update!(last_seen_at: 10.minutes.ago)
@ -193,7 +193,7 @@ describe "About page", type: :system do
expect(about_page.admins_list).to have_expand_button
displayed_admins = about_page.admins_list.users
expect(displayed_admins.size).to eq(10)
expect(displayed_admins.size).to eq(12)
expect(displayed_admins.map { |u| u[:username] }.first(3)).to eq(
[admins[1].username, admins[0].username, admins[2].username],
)
@ -203,7 +203,7 @@ describe "About page", type: :system do
about_page.visit
displayed_admins = about_page.admins_list.users
expect(displayed_admins.size).to eq(10)
expect(displayed_admins.size).to eq(12)
expect(about_page.admins_list).to be_expandable
@ -212,23 +212,23 @@ describe "About page", type: :system do
expect(about_page.admins_list).to be_collapsible
displayed_admins = about_page.admins_list.users
expect(displayed_admins.size).to eq(13) # 12 fabricated for this spec group and 1 global
expect(displayed_admins.size).to eq(15) # 14 fabricated for this spec group and 1 global
about_page.admins_list.collapse
expect(about_page.admins_list).to be_expandable
displayed_admins = about_page.admins_list.users
expect(displayed_admins.size).to eq(10)
expect(displayed_admins.size).to eq(12)
end
it "doesn't show an expand/collapse button when there are fewer than 10 admins" do
it "doesn't show an expand/collapse button when there are fewer than 12 admins" do
User.where(id: admins.first(7).map(&:id)).destroy_all
about_page.visit
displayed_admins = about_page.admins_list.users
expect(displayed_admins.size).to eq(6)
expect(displayed_admins.size).to eq(8)
expect(about_page.admins_list).to have_no_expand_button
end
@ -273,9 +273,9 @@ describe "About page", type: :system do
describe "our moderators section" do
before { User.update_all(last_seen_at: 1.month.ago) }
fab!(:moderators) { Fabricate.times(13, :moderator) }
fab!(:moderators) { Fabricate.times(15, :moderator) }
it "displays only the 10 most recently seen moderators when there are more than 10 moderators" do
it "displays only the 12 most recently seen moderators when there are more than 12 moderators" do
moderators[10].update!(last_seen_at: 5.hours.ago)
moderators[3].update!(last_seen_at: 2.hours.ago)
moderators[5].update!(last_seen_at: 13.hours.ago)
@ -284,7 +284,7 @@ describe "About page", type: :system do
expect(about_page.moderators_list).to have_expand_button
displayed_mods = about_page.moderators_list.users
expect(displayed_mods.size).to eq(10)
expect(displayed_mods.size).to eq(12)
expect(displayed_mods.map { |u| u[:username] }.first(3)).to eq(
[moderators[3].username, moderators[10].username, moderators[5].username],
)
@ -294,7 +294,7 @@ describe "About page", type: :system do
about_page.visit
displayed_mods = about_page.moderators_list.users
expect(displayed_mods.size).to eq(10)
expect(displayed_mods.size).to eq(12)
expect(about_page.moderators_list).to be_expandable
@ -303,23 +303,23 @@ describe "About page", type: :system do
expect(about_page.moderators_list).to be_collapsible
displayed_mods = about_page.moderators_list.users
expect(displayed_mods.size).to eq(14) # 13 fabricated for this spec group and 1 global
expect(displayed_mods.size).to eq(16) # 15 fabricated for this spec group and 1 global
about_page.moderators_list.collapse
expect(about_page.moderators_list).to be_expandable
displayed_mods = about_page.moderators_list.users
expect(displayed_mods.size).to eq(10)
expect(displayed_mods.size).to eq(12)
end
it "doesn't show an expand/collapse button when there are fewer than 10 moderators" do
it "doesn't show an expand/collapse button when there are fewer than 12 moderators" do
User.where(id: moderators.first(10).map(&:id)).destroy_all
about_page.visit
displayed_mods = about_page.moderators_list.users
expect(displayed_mods.size).to eq(4)
expect(displayed_mods.size).to eq(6)
expect(about_page.moderators_list).to have_no_expand_button
end