github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-21 18:12:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: topic and post counts are not updated when ownership of a post is changed

Browse Source
This commit is contained in:
Neil Lalonde
2015-03-02 11:17:11 -05:00
parent 64d0d12632
commit 1bf4f34049
5 changed files with 107 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
spec/controllers/topics_controller_spec.rb
View File

@ -222,40 +222,23 @@ describe TopicsController do
let(:topic) { Fabricate(:topic) }
let(:user_a) { Fabricate(:user) }
let(:p1) { Fabricate(:post, topic_id: topic.id) }
let(:p2) { Fabricate(:post, topic_id: topic.id) }
it "raises an error with a parameter missing" do
expect { xhr :post, :change_post_owners, topic_id: 111, post_ids: [1,2,3] }.to raise_error(ActionController::ParameterMissing)
expect { xhr :post, :change_post_owners, topic_id: 111, username: 'user_a' }.to raise_error(ActionController::ParameterMissing)
end
it "calls PostRevisor" do
PostRevisor.any_instance.expects(:revise!)
it "calls PostOwnerChanger" do
PostOwnerChanger.any_instance.expects(:change_owner!).returns(true)
xhr :post, :change_post_owners, topic_id: topic.id, username: user_a.username_lower, post_ids: [p1.id]
expect(response).to be_success
end
it "changes the user" do
old_user = p1.user
xhr :post, :change_post_owners, topic_id: topic.id, username: user_a.username_lower, post_ids: [p1.id]
p1.reload
expect(old_user).not_to eq(p1.user)
end
# Make sure that p1.reload isn't changing the user for us
it "is not an artifact of the framework" do
old_user = p1.user
# xhr :post, :change_post_owners, topic_id: topic.id, username: user_a.username_lower, post_ids: [p1.id]
p1.reload
expect(p1.user).not_to eq(nil)
expect(old_user).to eq(p1.user)
end
let(:p2) { Fabricate(:post, topic_id: topic.id) }
it "changes multiple posts" do
# an integration test
xhr :post, :change_post_owners, topic_id: topic.id, username: user_a.username_lower, post_ids: [p1.id, p2.id]
p1.reload
p2.reload
p1.reload; p2.reload
expect(p1.user).not_to eq(nil)
expect(p1.user).to eq(p2.user)
end