DEV: Allow run_second_factor! to be used before login (#25420)

In a handful of situations, we need to verify a user's 2fa credentials before `current_user` is assigned. For example: login, email_login and change-email confirmation. This commit adds an explicit `target_user:` parameter to the centralized 2fa system so that it can be used for those situations.

For safety and clarity, this new parameter only works for anon. If some user is logged in, and target_user is set to a different user, an exception will be raised.
This commit is contained in:
David Taylor
2024-01-29 12:28:47 +00:00
committed by GitHub
parent 8e32c11ab4
commit 1bfccdd4f2
8 changed files with 259 additions and 152 deletions

View File

@ -10,12 +10,12 @@ RSpec.describe SecondFactor::AuthManager do
end
def create_manager(action)
SecondFactor::AuthManager.new(guardian, action)
SecondFactor::AuthManager.new(guardian, action, target_user: user)
end
def create_action(request = nil)
request ||= create_request
TestSecondFactorAction.new(guardian, request)
TestSecondFactorAction.new(guardian, request, target_user: user)
end
def stage_challenge(successful:)