From 1cf4a0d6045de22e2c4eb6a9b2b49c706f78ae86 Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Mon, 20 Oct 2014 12:11:36 -0400 Subject: [PATCH] Rename "User Expansion" to the much clearer "User Card" --- .../components/discourse-action-history.js.es6 | 2 +- .../discourse/components/poster-avatar.js.es6 | 2 +- .../discourse/components/poster-name.js.es6 | 2 +- .../{user-expansion.js.es6 => user-card.js.es6} | 0 .../initializers/click-interceptor.js.es6 | 2 +- .../discourse/routes/application.js.es6 | 2 +- .../javascripts/discourse/routes/topic_route.js | 6 +++--- .../discourse/templates/application.hbs | 2 +- .../{user-expansion.hbs => user-card.hbs} | 0 .../discourse/templates/user/preferences.hbs | 8 ++++---- .../discourse/templates/user/stream.hbs | 4 ++-- .../discourse/views/topic-list-poster.js.es6 | 4 ++-- .../{user-expansion.js.es6 => user-card.js.es6} | 16 ++++++++-------- app/assets/stylesheets/desktop.scss | 2 +- .../{poster_expansion.scss => user-card.scss} | 2 +- app/controllers/users_controller.rb | 12 ++++++------ app/jobs/scheduled/clean_up_uploads.rb | 2 +- app/models/user_profile.rb | 10 +++++----- app/serializers/user_serializer.rb | 10 +++++----- config/locales/client.en.yml | 6 +++--- config/locales/client.pt_BR.yml | 2 +- .../20141020154935_rename_expansion_to_card.rb | 5 +++++ spec/controllers/users_controller_spec.rb | 12 ++++++------ spec/phantom_js/smoke_test.js | 2 +- spec/serializers/user_serializer_spec.rb | 6 +++--- .../integration/user-card-test.js.es6 | 13 +++++++++++++ .../integration/user-expansion-test.js.es6 | 13 ------------- 27 files changed, 76 insertions(+), 71 deletions(-) rename app/assets/javascripts/discourse/controllers/{user-expansion.js.es6 => user-card.js.es6} (100%) rename app/assets/javascripts/discourse/templates/{user-expansion.hbs => user-card.hbs} (100%) rename app/assets/javascripts/discourse/views/{user-expansion.js.es6 => user-card.js.es6} (82%) rename app/assets/stylesheets/desktop/{poster_expansion.scss => user-card.scss} (99%) create mode 100644 db/migrate/20141020154935_rename_expansion_to_card.rb create mode 100644 test/javascripts/integration/user-card-test.js.es6 delete mode 100644 test/javascripts/integration/user-expansion-test.js.es6 diff --git a/app/assets/javascripts/discourse/components/discourse-action-history.js.es6 b/app/assets/javascripts/discourse/components/discourse-action-history.js.es6 index d5cd675dae4..d941bca62c1 100644 --- a/app/assets/javascripts/discourse/components/discourse-action-history.js.es6 +++ b/app/assets/javascripts/discourse/components/discourse-action-history.js.es6 @@ -32,7 +32,7 @@ export default Em.Component.extend({ if (c.get('usersExpanded')) { var postUrl; c.get('users').forEach(function(u) { - iconsHtml += ""; + iconsHtml += ""; if (u.post_url) { postUrl = postUrl || u.post_url; } diff --git a/app/assets/javascripts/discourse/components/poster-avatar.js.es6 b/app/assets/javascripts/discourse/components/poster-avatar.js.es6 index 9b55540d072..4d534e31990 100644 --- a/app/assets/javascripts/discourse/components/poster-avatar.js.es6 +++ b/app/assets/javascripts/discourse/components/poster-avatar.js.es6 @@ -1,7 +1,7 @@ export default Ember.Component.extend({ tagName: 'a', attributeBindings: ['href'], - classNames: ['trigger-expansion'], + classNames: ['trigger-user-card'], href: Em.computed.alias('post.usernameUrl'), click: function(e) { diff --git a/app/assets/javascripts/discourse/components/poster-name.js.es6 b/app/assets/javascripts/discourse/components/poster-name.js.es6 index d9b7c32595d..be3ef940d8c 100644 --- a/app/assets/javascripts/discourse/components/poster-name.js.es6 +++ b/app/assets/javascripts/discourse/components/poster-name.js.es6 @@ -1,5 +1,5 @@ var PosterNameComponent = Em.Component.extend({ - classNames: ['names', 'trigger-expansion'], + classNames: ['names', 'trigger-user-card'], displayNameOnPosts: Discourse.computed.setting('display_name_on_posts'), // sanitize name for comparison diff --git a/app/assets/javascripts/discourse/controllers/user-expansion.js.es6 b/app/assets/javascripts/discourse/controllers/user-card.js.es6 similarity index 100% rename from app/assets/javascripts/discourse/controllers/user-expansion.js.es6 rename to app/assets/javascripts/discourse/controllers/user-card.js.es6 diff --git a/app/assets/javascripts/discourse/initializers/click-interceptor.js.es6 b/app/assets/javascripts/discourse/initializers/click-interceptor.js.es6 index 4cd97d71147..d788a0a4173 100644 --- a/app/assets/javascripts/discourse/initializers/click-interceptor.js.es6 +++ b/app/assets/javascripts/discourse/initializers/click-interceptor.js.es6 @@ -18,7 +18,7 @@ export default { $currentTarget.data('ember-action') || $currentTarget.data('auto-route') || $currentTarget.data('share-url') || - $currentTarget.data('user-expand') || + $currentTarget.data('user-card') || $currentTarget.hasClass('mention') || $currentTarget.hasClass('ember-view') || $currentTarget.hasClass('lightbox') || diff --git a/app/assets/javascripts/discourse/routes/application.js.es6 b/app/assets/javascripts/discourse/routes/application.js.es6 index 29f036f13c9..daacd5b8524 100644 --- a/app/assets/javascripts/discourse/routes/application.js.es6 +++ b/app/assets/javascripts/discourse/routes/application.js.es6 @@ -20,7 +20,7 @@ var ApplicationRoute = Discourse.Route.extend({ }, expandUser: function(user) { - this.controllerFor('user-expansion').show(user.get('username'), user.get('uploaded_avatar_id')); + this.controllerFor('user-card').show(user.get('username'), user.get('uploaded_avatar_id')); return true; }, diff --git a/app/assets/javascripts/discourse/routes/topic_route.js b/app/assets/javascripts/discourse/routes/topic_route.js index 462845ef71f..6ba0068ade4 100644 --- a/app/assets/javascripts/discourse/routes/topic_route.js +++ b/app/assets/javascripts/discourse/routes/topic_route.js @@ -27,13 +27,13 @@ Discourse.TopicRoute = Discourse.Route.extend({ // Modals that can pop up within a topic expandPostUser: function(post) { - this.controllerFor('user-expansion').show(post.get('username'), post.get('uploaded_avatar_id')); + this.controllerFor('user-card').show(post.get('username'), post.get('uploaded_avatar_id')); }, expandPostUsername: function(username) { username = username.replace(/^@/, ''); if (!Em.isEmpty(username)) { - this.controllerFor('user-expansion').show(username); + this.controllerFor('user-card').show(username); } }, @@ -172,7 +172,7 @@ Discourse.TopicRoute = Discourse.Route.extend({ // Clear the search context this.controllerFor('search').set('searchContext', null); - this.controllerFor('user-expansion').set('visible', false); + this.controllerFor('user-card').set('visible', false); var topicController = this.controllerFor('topic'), postStream = topicController.get('postStream'); diff --git a/app/assets/javascripts/discourse/templates/application.hbs b/app/assets/javascripts/discourse/templates/application.hbs index 75178ed4a27..8577bf11f34 100644 --- a/app/assets/javascripts/discourse/templates/application.hbs +++ b/app/assets/javascripts/discourse/templates/application.hbs @@ -2,7 +2,7 @@
{{outlet}} - {{render "user-expansion"}} + {{render "user-card"}}
{{render "modal"}} diff --git a/app/assets/javascripts/discourse/templates/user-expansion.hbs b/app/assets/javascripts/discourse/templates/user-card.hbs similarity index 100% rename from app/assets/javascripts/discourse/templates/user-expansion.hbs rename to app/assets/javascripts/discourse/templates/user-card.hbs diff --git a/app/assets/javascripts/discourse/templates/user/preferences.hbs b/app/assets/javascripts/discourse/templates/user/preferences.hbs index 6253a947066..f77de117b49 100644 --- a/app/assets/javascripts/discourse/templates/user/preferences.hbs +++ b/app/assets/javascripts/discourse/templates/user/preferences.hbs @@ -111,15 +111,15 @@
- +
{{image-uploader uploadUrl=imageUploadUrl - imageUrl=expansion_background + imageUrl=card_background instantDelete="true" - type="expansion_background"}} + type="card_background"}}
- {{i18n user.change_expansion_background.instructions}} + {{i18n user.change_card_background.instructions}}
{{/if}} diff --git a/app/assets/javascripts/discourse/templates/user/stream.hbs b/app/assets/javascripts/discourse/templates/user/stream.hbs index 26b175641c0..39792b31cbc 100644 --- a/app/assets/javascripts/discourse/templates/user/stream.hbs +++ b/app/assets/javascripts/discourse/templates/user/stream.hbs @@ -1,7 +1,7 @@ {{#grouped-each model.content}}