github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-20 23:41:31 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Serve RTL CSS for themes and components (#32916)

Browse Source 
Follow up to https://github.com/discourse/discourse/pull/32881

Stylesheet `<link>` tags for themes/components are aren't getting
included/rendered in the HTML document due to a missing check in
stylesheet manager. See
https://meta.discourse.org/t/ui-layout-broken-for-rtl-language-after-latest-update/367434?u=osama.
This commit is contained in:
Osama Sayegh
2025-05-27 03:15:05 +03:00
committed by GitHub
parent adc8dd29eb
commit 1de8960d2a
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/stylesheet/manager.rb
View File

@ -304,7 +304,7 @@ class Stylesheet::Manager
stylesheets = [] stylesheets = []
if is_theme_target if is_theme_target
scss_checker = ScssChecker.new(target, @theme_ids) scss_checker = ScssChecker.new(target.to_s.delete_suffix("_rtl"), @theme_ids)
themes = load_themes(@theme_ids) themes = load_themes(@theme_ids)
themes.each do |theme| themes.each do |theme|
theme_id = theme&.id theme_id = theme&.id

10
spec/lib/stylesheet/manager_spec.rb
View File

@ -45,6 +45,16 @@ RSpec.describe Stylesheet::Manager do
end end
end end
it "generates RTL stylesheets for themes with components" do
manager = manager(theme.id)
hrefs = manager.stylesheet_details(:common_theme_rtl, "all")
expect(hrefs.size).to eq(2)
expect(hrefs.map { |href| href[:theme_id] }).to contain_exactly(theme.id, child_theme.id)
expect(hrefs[0][:new_href]).to start_with("/stylesheets/common_theme_rtl_")
expect(hrefs[1][:new_href]).to start_with("/stylesheets/common_theme_rtl_")
end
it "generates the right links for non-theme targets" do it "generates the right links for non-theme targets" do
manager = manager(nil) manager = manager(nil)