github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-23 23:11:13 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Refactor translation overrides a bit (#28125)

Browse Source 
This is a small followup of
https://github.com/discourse/discourse/pull/28037.
This commit is contained in:
Loïc Guitaut
2024-07-30 03:56:46 +02:00
committed by GitHub
parent e9aa2c96e1
commit 1f5cbb9a44
3 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spec/lib/js_locale_helper_spec.rb
View File

@ -262,7 +262,9 @@ RSpec.describe JsLocaleHelper do
end
describe ".output_client_overrides" do
it "should not output deprecated translation overrides" do
subject(:client_overrides) { described_class.output_client_overrides("en") }
before do
Fabricate(
:translation_override,
locale: "en",
@ -276,9 +278,11 @@ RSpec.describe JsLocaleHelper do
value: "SHOULD_NOT_SHOW",
status: "deprecated",
)
end
expect(described_class.output_client_overrides("en").include? "SHOULD_SHOW").to eq(true)
expect(described_class.output_client_overrides("en").include? "SHOULD_NOT_SHOW").to eq(false)
it "does not output deprecated translation overrides" do
expect(client_overrides).to include("SHOULD_SHOW")
expect(client_overrides).not_to include("SHOULD_NOT_SHOW")
end
end
end