github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-23 17:51:03 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Make error in Discourse Hub more descriptive. (#6438)

Browse Source
This commit is contained in:
Bianca Nenciu
2018-10-09 17:05:31 +03:00
committed by Régis Hanol
parent 47f19adac8
commit 1fb1f4c790
2 changed files with 34 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
spec/components/discourse_hub_spec.rb
View File

@ -75,4 +75,25 @@ describe DiscourseHub do
end
end
end
describe '.collection_action' do
it 'should log a warning if status is not 200' do
stub_request(:get, (ENV['HUB_BASE_URL'] || "http://local.hub:3000/api")).
to_return(status: 500, body: "", headers: {})
Rails.logger.expects(:warn)
DiscourseHub.collection_action(:get, "")
end
it 'should log an error if response is invalid JSON' do
stub_request(:get, (ENV['HUB_BASE_URL'] || "http://local.hub:3000/api")).
to_return(status: 200, body: "this is not valid JSON", headers: {})
Rails.logger.expects(:error)
DiscourseHub.collection_action(:get, "")
end
end
end