github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-21 18:12:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Replace Twitter handles one at a time (#15870)

Browse Source 
Previously, all handles and hashtags were replaced in one go which could
result in a wrong result if a handle was a substring of another one.
This commit is contained in:
Dan Ungureanu
2022-02-09 13:54:02 +02:00
committed by GitHub
parent 5ff3a9c4bb
commit 1fb97f8bba
2 changed files with 29 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
spec/lib/twitter_api_spec.rb Normal file
View File

@ -0,0 +1,21 @@
# frozen_string_literal: true
require 'rails_helper'
describe TwitterApi do
context '.link_handles_in' do
it 'correctly replaces handles' do
expect(TwitterApi.send(:link_handles_in, "@foo @foobar")).to match_html <<~HTML
<a href='https://twitter.com/foo' target='_blank'>@foo</a> <a href='https://twitter.com/foobar' target='_blank'>@foobar</a>
HTML
end
end
context '.link_hashtags_in' do
it 'correctly replaces hashtags' do
expect(TwitterApi.send(:link_hashtags_in, "#foo #foobar")).to match_html <<~HTML
<a href='https://twitter.com/search?q=%23foo' target='_blank'>#foo</a> <a href='https://twitter.com/search?q=%23foobar' target='_blank'>#foobar</a>
HTML
end
end
end