github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-31 21:55:25 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Add server side uniqueness validations for Group#name and User#username.

Browse Source 
https://meta.discourse.org/t/groups-can-be-given-same-name-as-existing-username/74010
This commit is contained in:
Guo Xiang Tan
2018-04-02 18:17:06 +08:00
parent d2a8f40fb0
commit 221503cd10
4 changed files with 88 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/models/group.rb
View File

@ -43,7 +43,7 @@ class Group < ActiveRecord::Base
end
validate :name_format_validator
validates :name, presence: true, uniqueness: { case_sensitive: false }
validates :name, presence: true
validate :automatic_membership_email_domains_format_validator
validate :incoming_email_validator
validate :can_allow_membership_requests, if: :allow_membership_requests
@ -597,7 +597,19 @@ class Group < ActiveRecord::Base
def name_format_validator
self.name.strip!
UsernameValidator.perform_validation(self, 'name')
self.name.downcase!
UsernameValidator.perform_validation(self, 'name') || begin
if will_save_change_to_name?
existing = Group.exec_sql(
User::USERNAME_EXISTS_SQL, username: self.name
).values.present?
if existing
errors.add(:name, I18n.t("activerecord.errors.messages.taken"))
end
end
end
end
def automatic_membership_email_domains_format_validator