github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-06 11:54:41 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Compile theme migrations javascript files when running theme qunit (#25219)

Browse Source 
Why this change?

Currently, is it hard to iteratively write a theme settings migrations
because our theme migrations system does not rollback. Therefore, we
want to allow theme developers to be able to write QUnit tests for their
theme migrations files enabling them to iteratively write their theme
migrations.

What does this change do?

1. Update `Theme#baked_js_tests_with_digest` to include all `ThemeField`
records of `ThemeField#target` equal to `migrations`. Note that we do
not include the `settings` and `themePrefix` variables for migration files.

2. Don't minify JavaScript test files becasue it makes debugging in
   development hard.
This commit is contained in:
Alan Guo Xiang Tan
2024-01-16 09:50:44 +08:00
committed by GitHub
parent fd7c6f1ca8
commit 22614ca85b
4 changed files with 46 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/requests/theme_javascripts_controller_spec.rb
View File

@ -229,13 +229,5 @@ RSpec.describe ThemeJavascriptsController do
expect(response.status).to eq(200)
expect(response.body).to include("assert.ok(343434);")
end
it "includes inline sourcemap" do
ThemeJavascriptCompiler.enable_terser!
content, digest = component.baked_js_tests_with_digest
get "/theme-javascripts/tests/#{component.id}-#{digest}.js"
expect(response.status).to eq(200)
expect(response.body).to include("//# sourceMappingURL=data:application/json;base64,")
end
end
end