DEV: Replace #pluck_first freedom patch with AR #pick in core (#19893)

The #pluck_first freedom patch, first introduced by @danielwaterworth has served us well, and is used widely throughout both core and plugins. It seems to have been a common enough use case that Rails 6 introduced it's own method #pick with the exact same implementation. This allows us to retire the freedom patch and switch over to the built-in ActiveRecord method.

There is no replacement for #pluck_first!, but a quick search shows we are using this in a very limited capacity, and in some cases incorrectly (by assuming a nil return rather than an exception), which can quite easily be replaced with #pick plus some extra handling.
This commit is contained in:
Ted Johansson
2023-02-13 12:39:45 +08:00
committed by GitHub
parent a90ad52dff
commit 25a226279a
56 changed files with 112 additions and 123 deletions

View File

@ -39,9 +39,7 @@ class ApplicationRequest < ActiveRecord::Base
def self.req_id(date, req_type, retries = 0)
req_type_id = req_types[req_type]
# a poor man's upsert
id = where(date: date, req_type: req_type_id).pluck_first(:id)
id ||= create!(date: date, req_type: req_type_id, count: 0).id
create_or_find_by!(date: date, req_type: req_type_id).id
rescue StandardError # primary key violation
if retries == 0
req_id(date, req_type, 1)