github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-31 07:48:02 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Switch to data attributes to represent sidebar section name (#20771)

Browse Source 
Data attributes are less restrictive than the class attribute.
This commit is contained in:
Alan Guo Xiang Tan
2023-03-23 13:09:45 +08:00
committed by GitHub
parent d87e78616d
commit 2d46824a87
15 changed files with 455 additions and 244 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
spec/system/custom_sidebar_sections_spec.rb
View File

@ -136,11 +136,16 @@ describe "Custom sidebar sections", type: :system, js: true do
visit("/latest")
expect(page).to have_button("Public section")
find(".sidebar-section-public-section").hover
find(".sidebar-section[data-section-name='public-section']").hover
expect(page).not_to have_css(
".sidebar-section-public-section button.sidebar-section-header-button",
".sidebar-section[data-section-name='public-section'] button.sidebar-section-header-button",
)
expect(page).not_to have_css(
".sidebar-section[data-section-name='public-section'] .d-icon-globe",
)
expect(page).not_to have_css(".sidebar-section-public-section .d-icon-globe")
end
it "allows the user to delete custom section" do
@ -170,7 +175,7 @@ describe "Custom sidebar sections", type: :system, js: true do
expect(page).to have_button("Public section")
expect(sidebar).to have_link("Sidebar Tags")
expect(page).to have_css(".sidebar-section-public-section .d-icon-globe")
expect(page).to have_css(".sidebar-section[data-section-name='public-section'] .d-icon-globe")
sidebar.edit_custom_section("Public section")
section_modal.fill_name("Edited public section")