github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-01 01:05:11 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Fix flaky twitter onebox behavior (#18141)

Browse Source 
The order in which Onebox engines are loaded is not guaranteed. Occasionally during tests, the twitter engine would be loaded before the instagram engine, and cause the Instagram Onebox spec to fail due to the lack of `Onebox.options.twitter_client`.

This commit makes the load order of Onebox engines consistent, and fixes the issue in the twitter_status_onebox.
This commit is contained in:
David Taylor
2022-08-31 01:42:55 +01:00
committed by GitHub
parent 2595e368b1
commit 2e00d4d024
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/onebox/engine/twitter_status_onebox.rb
View File

@ -11,7 +11,8 @@ module Onebox
always_https
def self.===(other)
!Onebox.options.twitter_client.twitter_credentials_missing? && super
client = Onebox.options.twitter_client
client && !client.twitter_credentials_missing? && super
end
def http_params