On signup, handle duplicate key errors on email and username better

This commit is contained in:
Neil Lalonde
2013-03-07 14:56:28 -05:00
parent 1133d90dcc
commit 2ebe0336ae
4 changed files with 15 additions and 4 deletions

View File

@ -380,7 +380,7 @@ describe UsersController do
it_should_behave_like 'honeypot fails'
end
shared_examples_for 'failed signup due to password problem' do
shared_examples_for 'failed signup' do
it 'should not create a new User' do
expect { xhr :post, :create, create_params }.to_not change { User.count }
end
@ -394,12 +394,20 @@ describe UsersController do
context 'when password is blank' do
let(:create_params) { {:name => @user.name, :username => @user.username, :password => "", :email => @user.email} }
it_should_behave_like 'failed signup due to password problem'
it_should_behave_like 'failed signup'
end
context 'when password param is missing' do
let(:create_params) { {:name => @user.name, :username => @user.username, :email => @user.email} }
it_should_behave_like 'failed signup due to password problem'
it_should_behave_like 'failed signup'
end
context 'when InvalidStatement is raised' do
before do
User.any_instance.stubs(:save).raises(ActiveRecord::StatementInvalid)
end
let(:create_params) { {:name => @user.name, :username => @user.username, :password => "strongpassword", :email => @user.email} }
it_should_behave_like 'failed signup'
end
end