github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 16:11:08 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FEATURE: Onebox can match engines based on the content_type (#13876)

Browse Source 
* FEATURE: Onebox can match engines based on the content_type

`FinalDestination` now returns the `content_type` of a resolved URL.

`Oneboxer` passes this value to `Onebox` itself. Onebox engines can now specify a `matches_content_type` regex of content_types that the engine can handle, regardless of the URL.

`ImageOnebox` will match URLs with a content type of `image/png`, `jpg`, `gif`, `bmp`, `tif`, etc.

This will allow images that exist at a URL without a file type extension to be correctly rendered, assuming a valid `content_type` is returned.
This commit is contained in:
jbrw
2021-07-30 13:36:30 -04:00
committed by GitHub
parent f0d048b42a
commit 2f28ba318c
9 changed files with 65 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/onebox/engine.rb
View File

@ -96,6 +96,12 @@ module Onebox
end
module ClassMethods
def handles_content_type?(other)
if other && class_variable_defined?(:@@matcher_content_type)
!!(other.to_s =~ class_variable_get(:@@matcher_content_type))
end
end
def ===(other)
if other.kind_of?(URI)
!!(other.to_s =~ class_variable_get(:@@matcher))
@ -112,6 +118,10 @@ module Onebox
class_variable_set :@@matcher, r
end
def matches_content_type(ct)
class_variable_set :@@matcher_content_type, ct
end
def requires_iframe_origins(*origins)
class_variable_set :@@iframe_origins, origins
end