github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-23 12:51:24 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Editing a topic's title should be rate limited too.

Browse Source
This commit is contained in:
Robin Ward
2014-10-07 16:46:01 -04:00
parent 11b52d1334
commit 2fbfc9dffa
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/controllers/topics_controller.rb
View File

@ -129,6 +129,7 @@ class TopicsController < ApplicationController
Topic.transaction do Topic.transaction do
success = topic.save success = topic.save
success &= topic.change_category_to_id(params[:category_id].to_i) unless topic.private_message? success &= topic.change_category_to_id(params[:category_id].to_i) unless topic.private_message?
EditRateLimiter.new(current_user).performed!
end end
# this is used to return the title to the client as it may have been changed by "TextCleaner" # this is used to return the title to the client as it may have been changed by "TextCleaner"

6
spec/controllers/topics_controller_spec.rb
View File

@ -770,6 +770,12 @@ describe TopicsController do
expect(response).not_to be_success expect(response).not_to be_success
end end
it "returns errors when the rate limit is exceeded" do
EditRateLimiter.any_instance.expects(:performed!).raises(RateLimiter::LimitExceeded.new(60))
xhr :put, :update, topic_id: @topic.id, slug: @topic.title, title: 'This is a new title for the topic'
response.should_not be_success
end
it "returns errors with invalid categories" do it "returns errors with invalid categories" do
Topic.any_instance.expects(:change_category_to_id).returns(false) Topic.any_instance.expects(:change_category_to_id).returns(false)
xhr :put, :update, topic_id: @topic.id, slug: @topic.title xhr :put, :update, topic_id: @topic.id, slug: @topic.title