github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-25 19:29:34 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Revert "FIX: ensures onSelect/onDeselect are called"

Browse Source 
This reverts commit 52eed7329429abffefb7df7aac469e188a0ae298.
This commit is contained in:
Joffrey JAFFEUX
2018-09-17 22:14:41 +02:00
parent 7f420b61cb
commit 2ff2c49908
2 changed files with 0 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/select-kit/components/single-select.js.es6
View File

@ -210,10 +210,6 @@ export default SelectKitComponent.extend({
}, },
select(computedContentItem) { select(computedContentItem) {
if (this.get("hasSelection")) {
this.deselect(this.get("selection.value"));
}
if ( if (
!computedContentItem || !computedContentItem ||
computedContentItem.__sk_row_type === "noneRow" computedContentItem.__sk_row_type === "noneRow"

52
test/javascripts/components/single-select-test.js.es6
View File

@ -835,55 +835,3 @@ componentTest("without forceEscape", {
); );
} }
}); });
componentTest("onSelect", {
template:
"<div class='test-external-action'></div>{{single-select content=content onSelect=(action externalAction)}}",
beforeEach() {
this.set("externalAction", actual => {
find(".test-external-action").text(actual);
});
this.set("content", ["red", "blue"]);
},
async test(assert) {
await this.get("subject").expand();
await this.get("subject").selectRowByValue("red");
assert.equal(
find(".test-external-action")
.text()
.trim(),
"red"
);
}
});
componentTest("onDeselect", {
template:
"<div class='test-external-action'></div>{{single-select content=content onDeselect=(action externalAction)}}",
beforeEach() {
this.set("externalAction", actual => {
find(".test-external-action").text(actual);
});
this.set("content", ["red", "blue"]);
},
async test(assert) {
await this.get("subject").expand();
await this.get("subject").selectRowByValue("red");
await this.get("subject").expand();
await this.get("subject").selectRowByValue("blue");
assert.equal(
find(".test-external-action")
.text()
.trim(),
"red"
);
}
});