FIX: Raise right response when post_action does not exist.

This commit is contained in:
Guo Xiang Tan
2017-04-27 17:29:31 +08:00
parent e4b9f72f9e
commit 304ace926e
2 changed files with 8 additions and 2 deletions

View File

@ -383,8 +383,8 @@ class PostsController < ApplicationController
PostAction.act(current_user, post, PostActionType.types[:bookmark])
else
post_action = PostAction.find_by(post_id: params[:post_id], user_id: current_user.id)
post = post_action.post
raise Discourse::InvalidParameters unless post_action
post = post_action&.post
raise Discourse::NotFound unless post_action
PostAction.remove_act(current_user, post, PostActionType.types[:bookmark])
end