github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-21 18:12:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: enable frozen string literal on all files

Browse Source 
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.

Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
This commit is contained in:
Sam Saffron
2019-05-03 08:17:27 +10:00
committed by Guo Xiang Tan
parent 4e1f25197d
commit 30990006a9
2201 changed files with 4482 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/discourse-narrative-bot/autoload/jobs/bot_input.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
module Jobs
class BotInput < Jobs::Base

2
plugins/discourse-narrative-bot/autoload/jobs/narrative_init.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
require_dependency 'user'
module Jobs

2
plugins/discourse-narrative-bot/autoload/jobs/narrative_timeout.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
module Jobs
class NarrativeTimeout < Jobs::Base
def execute(args)

2
plugins/discourse-narrative-bot/autoload/jobs/onceoff/grant_badges.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
module Jobs
module DiscourseNarrativeBot
class GrantBadges < ::Jobs::Onceoff

2
plugins/discourse-narrative-bot/autoload/jobs/onceoff/remap_old_bot_images.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
module Jobs
module DiscourseNarrativeBot
class RemapOldBotImages < ::Jobs::Onceoff

2
plugins/discourse-narrative-bot/autoload/jobs/send_default_welcome_message.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
module Jobs
class SendDefaultWelcomeMessage < Jobs::Base
def execute(args)

2
plugins/discourse-narrative-bot/db/fixtures/001_discobot.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
discobot_username = 'discobot'
def seed_primary_email

2
plugins/discourse-narrative-bot/db/fixtures/002_badges.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
Badge
.where(name: 'Complete New User Track')
.update_all(name: DiscourseNarrativeBot::NewUserNarrative::BADGE_NAME)

2
plugins/discourse-narrative-bot/lib/discourse_narrative_bot/actions.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
module DiscourseNarrativeBot
module Actions
TIMEOUT_DURATION = 900 # 15 mins

2
plugins/discourse-narrative-bot/lib/discourse_narrative_bot/advanced_user_narrative.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
module DiscourseNarrativeBot
class AdvancedUserNarrative < Base
I18N_KEY = "discourse_narrative_bot.advanced_user_narrative".freeze

2
plugins/discourse-narrative-bot/lib/discourse_narrative_bot/base.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
module DiscourseNarrativeBot
class Base
include Actions

2
plugins/discourse-narrative-bot/lib/discourse_narrative_bot/certificate_generator.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
module DiscourseNarrativeBot
class CertificateGenerator
def initialize(user, date)

2
plugins/discourse-narrative-bot/lib/discourse_narrative_bot/dice.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
module DiscourseNarrativeBot
class Dice
MAXIMUM_NUM_OF_DICE = 20

2
plugins/discourse-narrative-bot/lib/discourse_narrative_bot/magic_8_ball.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
module DiscourseNarrativeBot
class Magic8Ball
def self.generate_answer

2
plugins/discourse-narrative-bot/lib/discourse_narrative_bot/new_user_narrative.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'distributed_mutex'
module DiscourseNarrativeBot

2
plugins/discourse-narrative-bot/lib/discourse_narrative_bot/quote_generator.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'excon'
module DiscourseNarrativeBot

2
plugins/discourse-narrative-bot/lib/discourse_narrative_bot/track_selector.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
module DiscourseNarrativeBot
class TrackSelector
include Actions

2
plugins/discourse-narrative-bot/lib/discourse_narrative_bot/welcome_post_type_site_setting.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
module DiscourseNarrativeBot
class WelcomePostTypeSiteSetting
def self.valid_value?(val)

2
plugins/discourse-narrative-bot/plugin.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
# name: discourse-narrative-bot
# about: Introduces staff to Discourse
# version: 1.0

2
plugins/discourse-narrative-bot/spec/discourse_narrative_bot/advanced_user_narrative_spec.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe DiscourseNarrativeBot::AdvancedUserNarrative do

2
plugins/discourse-narrative-bot/spec/discourse_narrative_bot/new_user_narrative_spec.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe DiscourseNarrativeBot::NewUserNarrative do

2
plugins/discourse-narrative-bot/spec/discourse_narrative_bot/store_spec.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe DiscourseNarrativeBot::Store do

2
plugins/discourse-narrative-bot/spec/discourse_narrative_bot/track_selector_spec.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe DiscourseNarrativeBot::TrackSelector do

2
plugins/discourse-narrative-bot/spec/jobs/onceoff/grant_badges_spec.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe Jobs::DiscourseNarrativeBot::GrantBadges do

2
plugins/discourse-narrative-bot/spec/jobs/onceoff/remap_old_bot_iamges_spec.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe Jobs::DiscourseNarrativeBot::RemapOldBotImages do

2
plugins/discourse-narrative-bot/spec/jobs/send_default_welcome_message_spec.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe Jobs::SendDefaultWelcomeMessage do

2
plugins/discourse-narrative-bot/spec/lib/certificate_generator_spec.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe DiscourseNarrativeBot::CertificateGenerator do

2
plugins/discourse-narrative-bot/spec/requests/discobot_certificate_spec.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe "Discobot Certificate" do

2
plugins/discourse-narrative-bot/spec/requests/discobot_welcome_post_spec.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe "Discobot welcome post" do

2
plugins/discourse-narrative-bot/spec/user_spec.rb
View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe User do