github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-31 03:32:17 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

select-kit refactoring

Browse Source 
* better test helper
* more reliable tests
* more consistent use of data-value/data-name/title/aria-label everywhere: header and rows
This commit is contained in:
Joffrey JAFFEUX
2017-12-22 13:08:12 +01:00
committed by GitHub
parent 364e6fdd53
commit 315b9d796d
60 changed files with 827 additions and 641 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
plugins/discourse-details/test/javascripts/acceptance/details-button-test.js.es6
View File

@ -1,16 +1,24 @@
import { acceptance } from "helpers/qunit-helpers";
import { clearPopupMenuOptionsCallback } from "discourse/controllers/composer";
acceptance('Details Button', { loggedIn: true });
acceptance('Details Button', {
loggedIn: true,
beforeEach: function() {
clearPopupMenuOptionsCallback();
}
});
function findTextarea() {
return find(".d-editor-input")[0];
}
test('details button', (assert) => {
const popupMenu = selectKit('.toolbar-popup-menu-options');
visit("/");
click('#create-topic');
expandSelectKit('.toolbar-popup-menu-options');
selectKitSelectRow('insertDetails', { selector: '.toolbar-popup-menu-options'});
popupMenu.expand().selectRowByValue('insertDetails');
andThen(() => {
assert.equal(
@ -28,8 +36,7 @@ test('details button', (assert) => {
textarea.selectionEnd = textarea.value.length;
});
expandSelectKit('.toolbar-popup-menu-options');
selectKitSelectRow('insertDetails', { selector: '.toolbar-popup-menu-options'});
popupMenu.expand().selectRowByValue('insertDetails');
andThen(() => {
assert.equal(
@ -51,8 +58,7 @@ test('details button', (assert) => {
textarea.selectionEnd = 28;
});
expandSelectKit('.toolbar-popup-menu-options');
selectKitSelectRow('insertDetails', { selector: '.toolbar-popup-menu-options'});
popupMenu.expand().selectRowByValue('insertDetails');
andThen(() => {
assert.equal(
@ -74,8 +80,7 @@ test('details button', (assert) => {
textarea.selectionEnd = 29;
});
expandSelectKit('.toolbar-popup-menu-options');
selectKitSelectRow('insertDetails', { selector: '.toolbar-popup-menu-options'});
popupMenu.expand().selectRowByValue('insertDetails');
andThen(() => {
assert.equal(
@ -92,6 +97,7 @@ test('details button', (assert) => {
test('details button surrounds all selected text in a single details block', (assert) => {
const multilineInput = 'first line\n\nsecond line\n\nthird line';
const popupMenu = selectKit('.toolbar-popup-menu-options');
visit("/");
click('#create-topic');
@ -103,8 +109,7 @@ test('details button surrounds all selected text in a single details block', (as
textarea.selectionEnd = textarea.value.length;
});
expandSelectKit('.toolbar-popup-menu-options');
selectKitSelectRow('insertDetails', { selector: '.toolbar-popup-menu-options'});
popupMenu.expand().selectRowByValue('insertDetails');
andThen(() => {
assert.equal(