github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-30 07:11:34 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

select-kit refactoring

Browse Source 
* better test helper
* more reliable tests
* more consistent use of data-value/data-name/title/aria-label everywhere: header and rows
This commit is contained in:
Joffrey JAFFEUX
2017-12-22 13:08:12 +01:00
committed by GitHub
parent 364e6fdd53
commit 315b9d796d
60 changed files with 827 additions and 641 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
test/javascripts/acceptance/composer-test.js.es6
View File

@ -262,8 +262,8 @@ QUnit.test("Composer can toggle between edit and reply", assert => {
QUnit.test("Composer can toggle between reply and createTopic", assert => {
visit("/t/this-is-a-test-topic/9");
click('.topic-post:eq(0) button.reply');
expandSelectKit('.toolbar-popup-menu-options');
selectKitSelectRow('toggleWhisper', { selector: '.toolbar-popup-menu-options'});
selectKit('.toolbar-popup-menu-options').expand().selectRowByValue('toggleWhisper');
andThen(() => {
assert.ok(
@ -285,8 +285,7 @@ QUnit.test("Composer can toggle between reply and createTopic", assert => {
);
});
expandSelectKit('.toolbar-popup-menu-options');
selectKitSelectRow('toggleInvisible', { selector: '.toolbar-popup-menu-options'});
selectKit('.toolbar-popup-menu-options').expand().selectRowByValue('toggleInvisible');
andThen(() => {
assert.ok(