github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-23 13:51:03 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

select-kit refactoring

Browse Source 
* better test helper
* more reliable tests
* more consistent use of data-value/data-name/title/aria-label everywhere: header and rows
This commit is contained in:
Joffrey JAFFEUX
2017-12-22 13:08:12 +01:00
committed by GitHub
parent 364e6fdd53
commit 315b9d796d
60 changed files with 827 additions and 641 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
test/javascripts/components/list-setting-test.js.es6
View File

@ -11,15 +11,14 @@ componentTest('default', {
},
test(assert) {
expandSelectKit();
andThen(() => {
assert.propEqual(selectKit().header.name(), 'bold,italic');
assert.equal(selectKit().header().title(), 'bold,italic');
assert.equal(selectKit().header().value(), 'bold,italic');
});
}
});
componentTest('with emptry string as value', {
componentTest('with empty string as value', {
template: '{{list-setting settingValue=settingValue}}',
beforeEach() {
@ -27,10 +26,8 @@ componentTest('with emptry string as value', {
},
test(assert) {
expandSelectKit();
andThen(() => {
assert.equal(selectKit().header.el.find(".selected-name").length, 0);
assert.equal(selectKit().header().value(), "");
});
}
});
@ -43,10 +40,8 @@ componentTest('with only setting value', {
},
test(assert) {
expandSelectKit();
andThen(() => {
assert.propEqual(selectKit().header.name(), 'bold,italic');
assert.equal(selectKit().header().value(), 'bold,italic');
});
}
});
@ -60,31 +55,31 @@ componentTest('interactions', {
},
test(assert) {
expandSelectKit();
const listSetting = selectKit();
selectKitSelectRow('underline');
listSetting.expand().selectRowByValue('underline');
andThen(() => {
assert.propEqual(selectKit().header.name(), 'bold,italic,underline');
assert.equal(listSetting.header().value(), 'bold,italic,underline');
});
selectKitFillInFilter('strike');
listSetting.fillInFilter('strike');
andThen(() => {
assert.equal(selectKit().highlightedRow.name(), 'strike');
assert.equal(listSetting.highlightedRow().value(), 'strike');
});
selectKit().keyboard.enter();
listSetting.keyboard().enter();
andThen(() => {
assert.propEqual(selectKit().header.name(), 'bold,italic,underline,strike');
assert.equal(listSetting.header().value(), 'bold,italic,underline,strike');
});
selectKit().keyboard.backspace();
selectKit().keyboard.backspace();
listSetting.keyboard().backspace();
listSetting.keyboard().backspace();
andThen(() => {
assert.equal(this.get('choices').length, 3, 'it removes the created content from original list');
assert.equal(listSetting.header().value(), 'bold,italic,underline');
});
}
});