github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-25 00:32:52 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: staff should always be allowed to create polls if they are enabled

Browse Source
This commit is contained in:
Joffrey JAFFEUX
2017-12-05 00:03:56 +01:00
committed by GitHub
parent 4af4081c39
commit 316d814130
8 changed files with 20 additions and 104 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
plugins/poll/spec/controllers/posts_controller_spec.rb
View File

@ -342,6 +342,8 @@ describe PostsController do
end
it "doesn’t cook the poll" do
log_in_user(Fabricate(:user, admin: true, trust_level: 4))
post :create, params: {
title: title, raw: "[poll]\n- A\n- B\n[/poll]"
}, format: :json
@ -408,13 +410,13 @@ describe PostsController do
end
end
describe "admin with insufficient trust level" do
describe "staff with insufficient trust level" do
before do
SiteSetting.poll_minimum_trust_level_to_create = 2
end
it "validates the post" do
log_in_user(Fabricate(:user, admin: true, trust_level: 1))
log_in_user(Fabricate(:user, moderator: true, trust_level: 1))
post :create, params: {
title: title, raw: "[poll]\n- A\n- B\n[/poll]"
@ -426,47 +428,4 @@ describe PostsController do
expect(json["polls"]["poll"]).to be
end
end
describe "staff" do
before do
SiteSetting.poll_minimum_trust_level_to_create = 4
end
describe "allow staff enabled" do
before do
SiteSetting.poll_allow_staff_to_create = true
end
it "validates the post" do
log_in_user(Fabricate(:user, moderator: true, trust_level: 1))
post :create, params: {
title: title, raw: "[poll]\n- A\n- B\n[/poll]"
}, format: :json
expect(response).to be_success
json = ::JSON.parse(response.body)
expect(json["cooked"]).to match("data-poll-")
expect(json["polls"]["poll"]).to be
end
end
describe "allow staff disabled" do
before do
SiteSetting.poll_allow_staff_to_create = false
end
it "invalidates the post" do
log_in_user(Fabricate(:user, moderator: true, trust_level: 1))
post :create, params: {
title: title, raw: "[poll]\n- A\n- B\n[/poll]"
}, format: :json
expect(response).not_to be_success
json = ::JSON.parse(response.body)
expect(json["errors"][0]).to eq(I18n.t("poll.insufficient_rights_to_create"))
end
end
end
end