github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-24 03:36:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Remove logical OR assignment of constants (#29201)

Browse Source 
Constants should always be only assigned once. The logical OR assignment
of a constant is a relic of the past before we used zeitwerk for
autoloading and had bugs where a file could be loaded twice resulting in
constant redefinition warnings.
This commit is contained in:
Alan Guo Xiang Tan
2024-10-16 10:09:07 +08:00
committed by GitHub
parent f3f37c9019
commit 322a3be2db
112 changed files with 267 additions and 267 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/static_controller.rb
View File

@ -145,7 +145,7 @@ class StaticController < ApplicationController
redirect_to(destination, allow_other_host: false)
end
FAVICON ||= -"favicon"
FAVICON = -"favicon"
# We need to be able to draw our favicon on a canvas, this happens when you enable the feature
# that draws the notification count on top of favicon (per user default off)