github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-26 17:24:29 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Remove mocks from tests.

Browse Source
This commit is contained in:
Guo Xiang Tan 2019-08-08 15:17:45 +08:00
parent 740e2a6025
commit 32b4bdaccd
1 changed files with 29 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
spec/models/reviewable_spec.rb
View File

@ -239,33 +239,50 @@ RSpec.describe Reviewable, type: :model do
fab!(:moderator) { Fabricate(:moderator) } fab!(:moderator) { Fabricate(:moderator) }
it "triggers a notification on create" do it "triggers a notification on create" do
Jobs.expects(:enqueue).with(:notify_reviewable, has_key(:reviewable_id)) reviewable = Fabricate(:reviewable_queued_post)
Fabricate(:reviewable_queued_post) job = Jobs::NotifyReviewable.jobs.last
expect(job["args"].first["reviewable_id"]).to eq(reviewable.id)
end end
it "triggers a notification on pending -> approve" do it "triggers a notification on pending -> approve" do
reviewable = Fabricate(:reviewable_queued_post) reviewable = Fabricate(:reviewable_queued_post)
Jobs.stubs(:enqueue)
Jobs.expects(:enqueue).with(:notify_reviewable, has_key(:reviewable_id)) expect do
reviewable.perform(moderator, :approve_post) reviewable.perform(moderator, :approve_post)
end.to change { Jobs::NotifyReviewable.jobs.size }.by(1)
job = Jobs::NotifyReviewable.jobs.last
expect(job["args"].first["reviewable_id"]).to eq(reviewable.id)
end end
it "triggers a notification on pending -> reject" do it "triggers a notification on pending -> reject" do
reviewable = Fabricate(:reviewable_queued_post) reviewable = Fabricate(:reviewable_queued_post)
Jobs.expects(:enqueue).with(:notify_reviewable, has_key(:reviewable_id))
reviewable.perform(moderator, :reject_post) expect do
reviewable.perform(moderator, :reject_post)
end.to change { Jobs::NotifyReviewable.jobs.size }.by(1)
job = Jobs::NotifyReviewable.jobs.last
expect(job["args"].first["reviewable_id"]).to eq(reviewable.id)
end end
it "doesn't trigger a notification on approve -> reject" do it "doesn't trigger a notification on approve -> reject" do
reviewable = Fabricate(:reviewable_queued_post, status: Reviewable.statuses[:approved]) reviewable = Fabricate(:reviewable_queued_post, status: Reviewable.statuses[:approved])
Jobs.expects(:enqueue).with(:notify_reviewable, has_key(:reviewable_id)).never
reviewable.perform(moderator, :reject_post) expect do
reviewable.perform(moderator, :reject_post)
end.to_not change { Jobs::NotifyReviewable.jobs.size }
end end
it "doesn't trigger a notification on reject -> approve" do it "doesn't trigger a notification on reject -> approve" do
reviewable = Fabricate(:reviewable_queued_post, status: Reviewable.statuses[:approved]) reviewable = Fabricate(:reviewable_queued_post, status: Reviewable.statuses[:rejected])
Jobs.expects(:enqueue).with(:notify_reviewable, has_key(:reviewable_id)).never
reviewable.perform(moderator, :reject_post) expect do
reviewable.perform(moderator, :approve_post)
end.to_not change { Jobs::NotifyReviewable.jobs.size }
end end
end end