github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-24 03:36:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: broken autocomplete on Android

Browse Source 
Android Chrome does not support keypress event, instead use keyup
This commit is contained in:
Sam Saffron
2016-02-23 17:06:15 +11:00
parent 6d22354ac3
commit 32d3dd22a0
1 changed files with 25 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
app/assets/javascripts/discourse/lib/autocomplete.js.es6
View File

@ -45,7 +45,7 @@ export default function(options) {
if (options === 'destroy') { if (options === 'destroy') {
Ember.run.cancel(inputTimeout); Ember.run.cancel(inputTimeout);
$(this).off('keypress.autocomplete') $(this).off('keyup.autocomplete')
.off('keydown.autocomplete') .off('keydown.autocomplete')
.off('paste.autocomplete') .off('paste.autocomplete')
.off('click.autocomplete'); .off('click.autocomplete');
@ -248,7 +248,15 @@ export default function(options) {
}); });
}; };
const SKIP = "skip";
var prevTerm = null;
const dataSource = (term, opts) => { const dataSource = (term, opts) => {
if (prevTerm === term) {
return SKIP;
}
prevTerm = term;
if (term.length !== 0 && term.trim().length === 0) { if (term.length !== 0 && term.trim().length === 0) {
closeAutocomplete(); closeAutocomplete();
return null; return null;
@ -257,9 +265,9 @@ export default function(options) {
} }
}; };
var updateAutoComplete = function(r) { const updateAutoComplete = function(r) {
if (completeStart === null) return; if (completeStart === null || r === SKIP) return;
if (r && r.then && typeof(r.then) === "function") { if (r && r.then && typeof(r.then) === "function") {
if (div) { if (div) {
@ -310,21 +318,21 @@ export default function(options) {
} }
}; };
$(this).on('keypress.autocomplete', function(e) { $(this).on('keyup.autocomplete', function(e) {
var caretPosition, term;
// keep hunting backwards till you hit a the @ key var caretPosition = Discourse.Utilities.caretPosition(me[0]);
if (options.key && e.which === options.key.charCodeAt(0)) {
caretPosition = Discourse.Utilities.caretPosition(me[0]); if (options.key && completeStart === null && caretPosition > 0) {
var prevChar = me.val().charAt(caretPosition - 1); var key = me[0].value[caretPosition-1];
if (checkTriggerRule() && (!prevChar || allowedLettersRegex.test(prevChar))) { if (key === options.key) {
completeStart = completeEnd = caretPosition; var prevChar = me.val().charAt(caretPosition-2);
updateAutoComplete(dataSource("", options)); if (checkTriggerRule() && (!prevChar || allowedLettersRegex.test(prevChar))) {
completeStart = completeEnd = caretPosition-1;
updateAutoComplete(dataSource("", options));
}
} }
} else if ((completeStart !== null) && (e.charCode !== 0)) { } else if (completeStart !== null) {
caretPosition = Discourse.Utilities.caretPosition(me[0]); var term = me.val().substring(completeStart + (options.key ? 1 : 0), caretPosition);
term = me.val().substring(completeStart + (options.key ? 1 : 0), caretPosition);
term += String.fromCharCode(e.charCode);
updateAutoComplete(dataSource(term, options)); updateAutoComplete(dataSource(term, options));
} }
}); });
@ -337,7 +345,7 @@ export default function(options) {
} }
if(options.allowAny){ if(options.allowAny){
// saves us wiring up a change event as well, keypress is while its pressed // saves us wiring up a change event as well
Ember.run.cancel(inputTimeout); Ember.run.cancel(inputTimeout);
inputTimeout = Ember.run.later(function(){ inputTimeout = Ember.run.later(function(){