github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 13:51:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: You can click to see your own PMs from flags

Browse Source 
Also refactors post action users to be a new object type since they can
have `post_url` which is not a field of a `User`
This commit is contained in:
Robin Ward
2015-09-30 12:28:13 -04:00
parent 97fbf09259
commit 33e58c0587
10 changed files with 80 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
spec/controllers/post_actions_controller_spec.rb
View File

@ -154,39 +154,4 @@ describe PostActionsController do
end
describe 'users' do
let!(:post) { Fabricate(:post, user: log_in) }
it 'raises an error without an id' do
expect {
xhr :get, :users, post_action_type_id: PostActionType.types[:like]
}.to raise_error(ActionController::ParameterMissing)
end
it 'raises an error without a post action type' do
expect {
xhr :get, :users, id: post.id
}.to raise_error(ActionController::ParameterMissing)
end
it "fails when the user doesn't have permission to see the post" do
Guardian.any_instance.expects(:can_see?).with(post).returns(false)
xhr :get, :users, id: post.id, post_action_type_id: PostActionType.types[:like]
expect(response).to be_forbidden
end
it 'raises an error when the post action type cannot be seen' do
Guardian.any_instance.expects(:can_see_post_actors?).with(instance_of(Topic), PostActionType.types[:like]).returns(false)
xhr :get, :users, id: post.id, post_action_type_id: PostActionType.types[:like]
expect(response).to be_forbidden
end
it 'succeeds' do
xhr :get, :users, id: post.id, post_action_type_id: PostActionType.types[:like]
expect(response).to be_success
end
end
end