github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-31 12:07:53 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Allow system tests to assert on values at the correct time (#27988)

Browse Source 
This adds some more assertions in system tests at certain instances during the test to minimise flakiness.
This commit is contained in:
Natalie Tay
2024-07-20 00:39:22 +08:00
committed by GitHub
parent 6e77107ccc
commit 346c9116b5
4 changed files with 20 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
spec/system/signup_spec.rb
View File

@ -95,6 +95,8 @@ shared_examples "signup scenarios" do
expect(signup_modal).to have_valid_fields
signup_modal.click_create_account
wait_for(timeout: 5) { User.find_by(username: "john") != nil }
visit "/"
login_modal.open
login_modal.fill_username("john")
@ -102,7 +104,6 @@ shared_examples "signup scenarios" do
login_modal.click_login
expect(login_modal).to have_content(I18n.t("login.not_approved"))
wait_for(timeout: 5) { User.find_by(username: "john") != nil }
user = User.find_by(username: "john")
user.update!(approved: true)
EmailToken.confirm(Fabricate(:email_token, user: user).token)