DEV: Make discourse_narrative_bot use Rails autoload (#26044)

Why this change?

Instead of manually loading files, we should just structure the plugin
so that it relies on Rails autoload strategy and avoid all the manual
`require_relative`s.

What does this change do?

1. Structure the plugin to use Rails autoloading convention
2. Remove onceff jobs that were added 5-6 years ago. There is no need to
   carry these jobs anymore after such a long time.
3. Move setting of `SiteSetting.discourse_narrative_bot_enabled` to
   `false` in the test environment from core into the plugin.
This commit is contained in:
Alan Guo Xiang Tan
2024-03-06 11:14:53 +08:00
committed by GitHub
parent 6b46b9ab78
commit 3491642f98
16 changed files with 116 additions and 258 deletions

View File

@ -95,11 +95,6 @@ Discourse::Application.configure do
# Most existing tests were written assuming allow_uncategorized_topics
# was enabled, so we should set it to true.
s.set_regardless_of_locale(:allow_uncategorized_topics, true)
# disable plugins
if ENV["LOAD_PLUGINS"] == "1"
s.set_regardless_of_locale(:discourse_narrative_bot_enabled, false)
end
end
SiteSetting.refresh!