github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 13:51:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: do not increment reply count manually (#26769)

Browse Source 
That could cause flakeyness in specs depending in which timing message bus would arrive and it's not necessary as it should be updated with `handleThreadOriginalMessageUpdate`.
This commit is contained in:
Joffrey JAFFEUX
2024-04-26 12:32:06 +02:00
committed by GitHub
parent a7f596da7a
commit 351d212e8a
6 changed files with 54 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/chat/spec/system/user_threads_spec.rb
View File

@ -118,7 +118,6 @@ RSpec.describe "User threads", type: :system do
it "updates the thread when another user replies" do
chat_thread_chain_bootstrap(channel: channel_1, users: [current_user, Fabricate(:user)])
thread = channel_1.threads.last
message = thread.original_message
last_user = Fabricate(:user)
chat_page.visit_user_threads
@ -126,7 +125,6 @@ RSpec.describe "User threads", type: :system do
last_message = Fabricate(:chat_message, thread: thread, user: last_user, use_service: true)
indicator = PageObjects::Components::Chat::ThreadIndicator.new(".c-user-thread")
expect(indicator).to have_reply_count(4)
expect(indicator).to have_participant(last_user)
expect(indicator).to have_excerpt(last_message.excerpt)