mirror of
https://github.com/discourse/discourse.git
synced 2025-05-22 16:11:08 +08:00
FIX: Apply crawler rate limits to cached requests (#27174)
This commit moves the logic for crawler rate limits out of the application controller and into the request tracker middleware. The reason for this move is to apply rate limits to all crawler requests instead of just the requests that make it to the application controller. Some requests are served early from the middleware stack without reaching the Rails app for performance reasons (e.g. `AnonymousCache`) which results in crawlers getting 200 responses even though they've reached their limits and should be getting 429 responses. Internal topic: t/128810.
This commit is contained in:
@ -1103,13 +1103,17 @@ RSpec.describe ApplicationController do
|
||||
end
|
||||
|
||||
describe "crawlers in slow_down_crawler_user_agents site setting" do
|
||||
before { RateLimiter.enable }
|
||||
before do
|
||||
Fabricate(:admin) # to prevent redirect to the wizard
|
||||
RateLimiter.enable
|
||||
|
||||
SiteSetting.slow_down_crawler_rate = 128
|
||||
SiteSetting.slow_down_crawler_user_agents = "badcrawler|problematiccrawler"
|
||||
end
|
||||
|
||||
use_redis_snapshotting
|
||||
|
||||
it "are rate limited" do
|
||||
SiteSetting.slow_down_crawler_rate = 128
|
||||
SiteSetting.slow_down_crawler_user_agents = "badcrawler|problematiccrawler"
|
||||
now = Time.zone.now
|
||||
freeze_time now
|
||||
|
||||
@ -1141,6 +1145,21 @@ RSpec.describe ApplicationController do
|
||||
get "/", headers: { "HTTP_USER_AGENT" => "iam problematiccrawler" }
|
||||
expect(response.status).to eq(200)
|
||||
end
|
||||
|
||||
context "with anonymous caching" do
|
||||
before do
|
||||
global_setting :anon_cache_store_threshold, 1
|
||||
Middleware::AnonymousCache.enable_anon_cache
|
||||
end
|
||||
|
||||
it "don't bypass crawler rate limits" do
|
||||
get "/", headers: { "HTTP_USER_AGENT" => "iam badcrawler" }
|
||||
expect(response.status).to eq(200)
|
||||
|
||||
get "/", headers: { "HTTP_USER_AGENT" => "iam badcrawler" }
|
||||
expect(response.status).to eq(429)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
describe "#banner_json" do
|
||||
|
Reference in New Issue
Block a user