github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 07:53:49 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: Change admin plugins list to follow UI guidelines (#28478)

Browse Source 
This commit introduces a little bit of duplication
since the old plugin UIs not using the new plugin show
page look different from ones like AI and Gamification
which have been converted. We can use the new admin
header component on the plugins list, but for the other
pages we are manually rendering a breadcrumb trail and
the list of plugin tabs.

Over time as we convert more plugins to use the new UI
guidelines and show page we can get rid of this duplication.
This commit is contained in:
Martin Brennan
2024-08-30 14:53:36 +10:00
committed by GitHub
parent 1f206349fd
commit 361e954c55
17 changed files with 257 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
plugins/automation/spec/system/admin_plugins_list_spec.rb Normal file
View File

@ -0,0 +1,54 @@
# frozen_string_literal: true
# NOTE: This spec covers core functionality, but it is much easier
# to test plugin related things inside an actual plugin.
describe "Admin Plugins List", type: :system, js: true do
fab!(:current_user) { Fabricate(:admin) }
let(:admin_plugins_list_page) { PageObjects::Pages::AdminPluginsList.new }
before do
sign_in(current_user)
SiteSetting.discourse_automation_enabled = true
end
let(:automation_plugin) do
Plugin::Instance.parse_from_source(File.join(Rails.root, "plugins", "automation", "plugin.rb"))
end
it "shows the list of plugins" do
admin_plugins_list_page.visit
expect(admin_plugins_list_page.find_plugin("automation")).to have_css(
".admin-plugins-list__name-with-badges .admin-plugins-list__name",
text: "Automation",
)
expect(admin_plugins_list_page.find_plugin("automation")).to have_css(
".admin-plugins-list__author",
text: I18n.t("admin_js.admin.plugins.author", { author: "Discourse" }),
)
expect(admin_plugins_list_page.find_plugin("automation")).to have_css(
".admin-plugins-list__about",
text: automation_plugin.metadata.about,
)
end
it "can toggle whether a plugin is enabled" do
admin_plugins_list_page.visit
toggle_switch =
PageObjects::Components::DToggleSwitch.new(
admin_plugins_list_page.plugin_row_selector("automation") +
" .admin-plugins-list__enabled .d-toggle-switch",
)
toggle_switch.toggle
expect(toggle_switch).to be_unchecked
expect(SiteSetting.discourse_automation_enabled).to eq(false)
toggle_switch.toggle
expect(toggle_switch).to be_checked
expect(SiteSetting.discourse_automation_enabled).to eq(true)
end
it "shows a navigation tab for each plugin that needs it" do
admin_plugins_list_page.visit
expect(admin_plugins_list_page).to have_plugin_tab("automation")
end
end