mirror of
https://github.com/discourse/discourse.git
synced 2025-05-28 13:51:18 +08:00
FIX: Don't display destroy reviewable button on client (#21226)
# Context https://meta.discourse.org/t/missing-translate-in-review-page/262604  An additional button was added as a result ofdd495a0e19
which was intended to grant access to deleting reviewable from the API. We were being too flexible by only checking if the user was an admin012aaf0ba3/lib/guardian.rb (L237)
where it should instead by scoped to check if the request was an API call. # Fix https://github.com/discourse/discourse/pull/21226/files#diff-0a2548be4b18bd4ef2dffb3ef8e44984d2fef7f037b53e98f67abea52ef75aa2R237 # Additions Added a new guard of `is_api?` https://github.com/discourse/discourse/pull/21226/files#diff-0a2548be4b18bd4ef2dffb3ef8e44984d2fef7f037b53e98f67abea52ef75aa2R657-R660 In `app/models/reviewable.rb` we check if the user has the permissions to the destroy action via the `Guardian`. To do this we were instantiating a new `Guardian` class which then caused us to lose the context of the request. The request is a necessary component in the guard of `is_api?` so we needed to pass the already defined Guardian from the `app/controllers/reviewables_controller.rb` to the `#perform` method to ensure the request is present.
This commit is contained in:
@ -4194,4 +4194,60 @@ RSpec.describe Guardian do
|
||||
expect(guardian.is_category_group_moderator?(category)).to eq(false)
|
||||
end
|
||||
end
|
||||
|
||||
describe "#can_delete_reviewable_queued_post" do
|
||||
context "when attempting to destroy a non personal reviewable" do
|
||||
it "returns true for api requests from admins" do
|
||||
api_key = Fabricate(:api_key).key
|
||||
queued_post = Fabricate(:reviewable_queued_post, created_by: user)
|
||||
opts = {
|
||||
"HTTP_API_USERNAME" => admin.username,
|
||||
"HTTP_API_KEY" => api_key,
|
||||
"REQUEST_METHOD" => "DELETE",
|
||||
"#{Auth::DefaultCurrentUserProvider::API_KEY_ENV}" => "foo",
|
||||
}
|
||||
|
||||
env = create_request_env(path: "/review/#{queued_post.id}.json").merge(opts)
|
||||
guardian = Guardian.new(admin, ActionDispatch::Request.new(env))
|
||||
expect(guardian.can_delete_reviewable_queued_post?(queued_post)).to eq(true)
|
||||
end
|
||||
|
||||
it "returns false for admin requests not via the API" do
|
||||
queued_post = Fabricate(:reviewable_queued_post, created_by: user)
|
||||
env =
|
||||
create_request_env(path: "/review/#{queued_post.id}.json").merge(
|
||||
{ "REQUEST_METHOD" => "DELETE" },
|
||||
)
|
||||
guardian = Guardian.new(admin, ActionDispatch::Request.new(env))
|
||||
expect(guardian.can_delete_reviewable_queued_post?(queued_post)).to eq(false)
|
||||
end
|
||||
|
||||
it "returns false for api requests from tl4 users" do
|
||||
api_key = Fabricate(:api_key).key
|
||||
queued_post = Fabricate(:reviewable_queued_post, created_by: user)
|
||||
opts = {
|
||||
"HTTP_API_USERNAME" => trust_level_4.username,
|
||||
"HTTP_API_KEY" => api_key,
|
||||
"REQUEST_METHOD" => "DELETE",
|
||||
"#{Auth::DefaultCurrentUserProvider::API_KEY_ENV}" => "foo",
|
||||
}
|
||||
|
||||
env = create_request_env(path: "/review/#{queued_post.id}.json").merge(opts)
|
||||
guardian = Guardian.new(trust_level_4, ActionDispatch::Request.new(env))
|
||||
expect(guardian.can_delete_reviewable_queued_post?(queued_post)).to eq(false)
|
||||
end
|
||||
end
|
||||
|
||||
context "when attempting to destroy your own reviewable" do
|
||||
it "returns true" do
|
||||
queued_post = Fabricate(:reviewable_queued_post, created_by: user)
|
||||
env =
|
||||
create_request_env(path: "/review/#{queued_post.id}.json").merge(
|
||||
{ "REQUEST_METHOD" => "DELETE" },
|
||||
)
|
||||
guardian = Guardian.new(user, ActionDispatch::Request.new(env))
|
||||
expect(guardian.can_delete_reviewable_queued_post?(queued_post)).to eq(true)
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
Reference in New Issue
Block a user