DEV: Prefer nested queries (#23464)

Some sites have a large number of categories and fetching the category
IDs or category topic IDs just to build another query can take a long
time or resources (i.e. memory).
This commit is contained in:
Bianca Nenciu
2023-09-25 19:38:54 +03:00
committed by GitHub
parent 1cc2c8fcb6
commit 3700514819
5 changed files with 5 additions and 7 deletions

View File

@ -931,7 +931,7 @@ class ApplicationController < ActionController::Base
Discourse
.cache
.fetch(key, expires_in: 10.minutes) do
category_topic_ids = Category.pluck(:topic_id).compact
category_topic_ids = Category.select(:topic_id).where.not(topic_id: nil)
@top_viewed =
TopicQuery
.new(nil, except_topic_ids: category_topic_ids)