github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-30 07:11:34 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: click handler position on rich editor details node (#32268)

Browse Source 
`pos` is the exact position of the click in the entire document

`nodePos` is the position of the clicked node itself

The idea is that we want the click to be the first position **within the
node**.

The previous code was checking for the first 2 positions of the entire
document.

I'd love to add a test for this, but it's very tricky.
This commit is contained in:
Renato Atilio
2025-04-14 14:06:54 -03:00
committed by GitHub
parent b9cef22c2f
commit 381f6e64e8
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
plugins/discourse-details/assets/javascripts/lib/rich-editor-extension.js
View File

@ -69,7 +69,8 @@ const extension = {
plugins: { plugins: {
props: { props: {
handleClickOn(view, pos, node, nodePos) { handleClickOn(view, pos, node, nodePos) {
if (pos > 2 || node.type.name !== "summary") { // if the click position in the document is not the first within the summary node
if (pos > nodePos + 1 || node.type.name !== "summary") {
return false; return false;
} }