github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 01:56:58 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Qunit tests were failing if your node was defaulting to IPV6 (#15773)

Browse Source 
This is now the default in newer node versions. The code that fails is a
workaround for another error :'(

This also upgrades `chrome-launcher` which helpers with debugging.
This commit is contained in:
Robin Ward
2022-02-02 10:56:03 -05:00
committed by GitHub
parent a1adc13125
commit 3837eb45b8
3 changed files with 15 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/run-qunit.js
View File

@ -61,7 +61,7 @@ async function runAllTests() {
// Workaround for intermittent CI error caused by
// https://github.com/GoogleChrome/chrome-launcher/issues/145
try {
protocol = await CDP({ port: chrome.port });
protocol = await CDP({ port: chrome.port, host: "127.0.0.1" });
} catch (e) {
if (e.message === "No inspectable targets" && connectAttempts < 50) {
connectAttempts++;
@ -279,7 +279,7 @@ function logQUnit() {
console.log("Slowest tests");
console.log("----------------------------------------------");
let ary = Object.keys(durations).map((key) => ({
key: key,
key,
value: durations[key],
}));
ary.sort((p1, p2) => p2.value - p1.value);