github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-29 01:31:35 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: early hints around_action -> after_action (#26423)

Browse Source 
Using around_action means `add_early_hint_header` is in the stack for every request, and gets included in the backtrace of any errors.

We can manage with an after_action instead, which avoids adding to the stack depth (and avoids people blaming me for unrelated application errors 😉)
This commit is contained in:
David Taylor
2024-04-04 14:37:44 +01:00
committed by GitHub
parent 2995da2625
commit 39ae85b0e7
3 changed files with 12 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
spec/helpers/application_helper_spec.rb
View File

@ -139,43 +139,31 @@ RSpec.describe ApplicationHelper do
end
describe "add_resource_preload_list" do
it "adds resources to the preload list when it's available" do
@asset_preload_links = []
it "adds resources to the preload list" do
add_resource_preload_list("/assets/start-discourse.js", "script")
add_resource_preload_list("/assets/discourse.css", "style")
expect(@asset_preload_links.size).to eq(2)
end
it "doesn't add resources to the preload list when it's not available" do
@asset_preload_links = nil
add_resource_preload_list("/assets/start-discourse.js", "script")
add_resource_preload_list("/assets/discourse.css", "style")
expect(@asset_preload_links).to eq(nil)
expect(controller.instance_variable_get(:@asset_preload_links).size).to eq(2)
end
it "adds resources to the preload list when preload_script is called" do
@asset_preload_links = []
helper.preload_script("start-discourse")
expect(@asset_preload_links.size).to eq(1)
expect(controller.instance_variable_get(:@asset_preload_links).size).to eq(1)
end
it "adds resources to the preload list when discourse_stylesheet_link_tag is called" do
@asset_preload_links = []
helper.discourse_stylesheet_link_tag(:desktop)
expect(@asset_preload_links.size).to eq(1)
expect(controller.instance_variable_get(:@asset_preload_links).size).to eq(1)
end
it "adds resources as the correct type" do
@asset_preload_links = []
helper.discourse_stylesheet_link_tag(:desktop)
helper.preload_script("start-discourse")
expect(@asset_preload_links[0]).to match(/as="style"/)
expect(@asset_preload_links[1]).to match(/as="script"/)
expect(controller.instance_variable_get(:@asset_preload_links)[0]).to match(/as="style"/)
expect(controller.instance_variable_get(:@asset_preload_links)[1]).to match(/as="script"/)
end
end