github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-17 15:02:35 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Assert for 200 response code to avoid changing magic helper in the future.

Browse Source
This commit is contained in:
Guo Xiang Tan
2018-06-07 16:11:09 +08:00
parent 3533bdb83f
commit 3a8f69c3d2
57 changed files with 498 additions and 498 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
spec/controllers/admin/users_controller_spec.rb
View File

@ -15,7 +15,7 @@ describe Admin::UsersController do
context '#index' do
it 'returns success' do
get :index, format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
end
it 'returns JSON' do
@ -48,7 +48,7 @@ describe Admin::UsersController do
context 'an existing user' do
it 'returns success' do
get :show, params: { id: @user.id }, format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
end
end
@ -135,7 +135,7 @@ describe Admin::UsersController do
format: :json
}
)
expect(response).to be_successful
expect(response.status).to eq(200)
user.reload
expect(user).to be_suspended
@ -160,7 +160,7 @@ describe Admin::UsersController do
it "can have an associated post" do
put(:suspend, params: suspend_params)
expect(response).to be_successful
expect(response.status).to eq(200)
log = UserHistory.where(target_user_id: user.id).order('id desc').first
expect(log).to be_present
@ -171,7 +171,7 @@ describe Admin::UsersController do
put(:suspend, params: suspend_params.merge(post_action: 'delete'))
post.reload
expect(post.deleted_at).to be_present
expect(response).to be_successful
expect(response.status).to eq(200)
end
it "can edit an associated post" do
@ -182,7 +182,7 @@ describe Admin::UsersController do
post.reload
expect(post.deleted_at).to be_blank
expect(post.raw).to eq("this is the edited content")
expect(response).to be_successful
expect(response.status).to eq(200)
end
end
@ -205,7 +205,7 @@ describe Admin::UsersController do
format: :json
}
)
expect(response).to be_successful
expect(response.status).to eq(200)
log = UserHistory.where(target_user_id: user.id).order('id desc').first
expect(log).to be_present
@ -274,7 +274,7 @@ describe Admin::UsersController do
group_id: group.id, user_id: user.id
}, format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
expect(GroupUser.where(user_id: user.id, group_id: group.id).exists?).to eq(true)
group_history = GroupHistory.last
@ -288,7 +288,7 @@ describe Admin::UsersController do
group_id: group.id, user_id: user.id
}, format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
end
end
@ -378,7 +378,7 @@ describe Admin::UsersController do
@another_user.reload
expect(@another_user.trust_level).to eq(2)
expect(response).to be_successful
expect(response.status).to eq(200)
end
it "raises no error when demoting a user below their current trust level (locks trust level)" do
@ -394,7 +394,7 @@ describe Admin::UsersController do
level: TrustLevel[0]
}, format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
@another_user.reload
expect(@another_user.trust_level).to eq(TrustLevel[0])
expect(@another_user.manual_locked_trust_level).to eq(TrustLevel[0])
@ -474,7 +474,7 @@ describe Admin::UsersController do
users: [reject_me.id, reject_me_too.id]
}, format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
json = ::JSON.parse(response.body)
expect(json['success'].to_i).to eq(2)
expect(json['failed'].to_i).to eq(0)
@ -493,7 +493,7 @@ describe Admin::UsersController do
users: [reject_me.id, reject_me_too.id]
}, format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
json = ::JSON.parse(response.body)
expect(json['success'].to_i).to eq(1)
expect(json['failed'].to_i).to eq(1)
@ -506,7 +506,7 @@ describe Admin::UsersController do
users: [reject_me.id]
}, format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
json = ::JSON.parse(response.body)
expect(json['success'].to_i).to eq(0)
expect(json['failed'].to_i).to eq(1)
@ -538,7 +538,7 @@ describe Admin::UsersController do
it "doesn't return an error if delete_posts == true" do
delete :destroy, params: { id: delete_me.id, delete_posts: true }, format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
end
end
@ -555,7 +555,7 @@ describe Admin::UsersController do
it "returns success" do
put :activate, params: { user_id: @reg_user.id }, format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
json = ::JSON.parse(response.body)
expect(json['success']).to eq("OK")
end
@ -567,7 +567,7 @@ describe Admin::UsersController do
expect(@reg_user.email_confirmed?).to eq(false)
put :activate, params: { user_id: @reg_user.id }, format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
@reg_user.reload
expect(@reg_user.email_confirmed?).to eq(true)
@ -581,7 +581,7 @@ describe Admin::UsersController do
it "returns success" do
put :log_out, params: { user_id: @reg_user.id }, format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
json = ::JSON.parse(response.body)
expect(json['success']).to eq("OK")
end
@ -612,7 +612,7 @@ describe Admin::UsersController do
it "punishes the user for spamming" do
put :silence, params: { user_id: @reg_user.id }, format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
@reg_user.reload
expect(@reg_user).to be_silenced
end
@ -626,7 +626,7 @@ describe Admin::UsersController do
post_action: 'edit',
post_edit: "this is the new contents for the post"
}, format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
silence_post.reload
expect(silence_post.raw).to eq("this is the new contents for the post")
@ -742,7 +742,7 @@ describe Admin::UsersController do
name: 'Bill', username: 'bill22', email: 'bill@bill.com'
}, format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
u = User.find_by_email('bill@bill.com')
expect(u.name).to eq("Bill")
@ -758,7 +758,7 @@ describe Admin::UsersController do
name: 'Bill', username: 'bill22', email: 'bill@bill.com', send_email: '0'
}, format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
json = ::JSON.parse(response.body)
expect(json["password_url"]).to be_present
end
@ -806,7 +806,7 @@ describe Admin::UsersController do
sso.email = "bob2@bob.com"
post :sync_sso, params: Rack::Utils.parse_query(sso.payload), format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
user.reload
expect(user.email).to eq("bob2@bob.com")
@ -820,7 +820,7 @@ describe Admin::UsersController do
sso.email = "dr@claw.com"
sso.external_id = "2"
post :sync_sso, params: Rack::Utils.parse_query(sso.payload), format: :json
expect(response).to be_successful
expect(response.status).to eq(200)
user = User.find_by_email('dr@claw.com')
expect(user).to be_present