FIX: Error message for 403 when featuring topic on profile (#9149)

This commit is contained in:
Mark VanLandingham
2020-03-09 11:41:07 -05:00
committed by GitHub
parent 5037b80c9c
commit 3ad5cb0cbc
3 changed files with 9 additions and 1 deletions

View File

@ -1362,7 +1362,10 @@ class UsersController < ApplicationController
user = fetch_user_from_params
topic = Topic.find(params[:topic_id].to_i)
raise Discourse::InvalidAccess.new unless topic && guardian.can_feature_topic?(user, topic)
if !guardian.can_feature_topic?(user, topic)
return render_json_error(I18n.t('activerecord.errors.models.user_profile.attributes.featured_topic_id.invalid'), 403)
end
user.user_profile.update(featured_topic_id: topic.id)
render json: success_json
end