github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-04 19:14:43 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

REFACTOR: clicks controller specs to requests (#5929)

Browse Source
This commit is contained in:
OsamaSayegh
2018-06-07 07:57:29 +03:00
committed by Guo Xiang Tan
parent 2688cc6241
commit 3c96ee4b6f
2 changed files with 61 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

88
spec/controllers/clicks_controller_spec.rb
View File

@ -1,88 +0,0 @@
require 'rails_helper'
describe ClicksController do
context 'create' do
context 'missing params' do
it 'raises a 404 without a url' do
get :track, params: { post_id: 123 }
expect(response).to be_not_found
end
end
context 'correct params' do
let(:url) { "http://discourse.org" }
before do
request.headers.merge!('REMOTE_ADDR' => '192.168.0.1')
end
context "with a made up url" do
render_views
it "doesn't redirect" do
TopicLinkClick.expects(:create_from).returns(nil)
get :track, params: { url: 'http://discourse.org', post_id: 123 }
expect(response).not_to be_redirect
expect(response.body).to include(I18n.t("redirect_warning"))
end
end
context "with a valid url" do
it "redirects" do
TopicLinkClick.expects(:create_from).with(has_entries('url' => 'http://discourse.org/?hello=123')).returns(url)
get :track, params: { url: 'http://discourse.org/?hello=123', post_id: 123 }
expect(response).to redirect_to(url)
end
end
context 'with a post_id' do
it 'redirects' do
TopicLinkClick.expects(:create_from).with('url' => url, 'post_id' => '123', 'ip' => '192.168.0.1').returns(url)
get :track, params: { url: url, post_id: 123 }
expect(response).to redirect_to(url)
end
it "redirects links in whispers to staff members" do
log_in(:admin)
whisper = Fabricate(:post, post_type: Post.types[:whisper])
get :track, params: { url: url, post_id: whisper.id }
expect(response).to redirect_to(url)
end
it "doesn't redirect with the redirect=false param" do
TopicLinkClick.expects(:create_from).with('url' => url, 'post_id' => '123', 'ip' => '192.168.0.1', 'redirect' => 'false').returns(url)
get :track, params: { url: url, post_id: 123, redirect: 'false' }
expect(response).not_to be_redirect
end
end
context 'with a topic_id' do
it 'redirects' do
TopicLinkClick.expects(:create_from).with('url' => url, 'topic_id' => '789', 'ip' => '192.168.0.1').returns(url)
get :track, params: { url: url, topic_id: 789 }
expect(response).to redirect_to(url)
end
end
end
end
end