github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-25 22:24:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Remove broken CLI option in bin/turbo_rspec (#32388)

Browse Source 
The `--disable-system-tests` CLI arg does nothing
This commit is contained in:
Alan Guo Xiang Tan 2025-04-22 09:00:33 +08:00 committed by GitHub
parent d29d6e562d
commit 3cc2b8540f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
bin/turbo_rspec
View File

@ -15,7 +15,6 @@ profile = false
profile_print_slowest_examples_count = 10 profile_print_slowest_examples_count = 10
use_runtime_info = nil use_runtime_info = nil
enable_system_tests = nil enable_system_tests = nil
disable_system_tests = nil
retry_and_log_flaky_tests = ENV["DISCOURSE_TURBO_RSPEC_RETRY_AND_LOG_FLAKY_TESTS"].to_s == "1" retry_and_log_flaky_tests = ENV["DISCOURSE_TURBO_RSPEC_RETRY_AND_LOG_FLAKY_TESTS"].to_s == "1"
OptionParser OptionParser
@ -66,21 +65,12 @@ OptionParser
opts.on("--enable-system-tests", "Run the system tests (defaults false)") do opts.on("--enable-system-tests", "Run the system tests (defaults false)") do
enable_system_tests = true enable_system_tests = true
end end
opts.on("--disable-system-tests", "Don't run the system tests (defaults true)") do
disable_system_tests = true
end
end end
.parse!(ARGV) .parse!(ARGV)
if enable_system_tests && disable_system_tests
STDERR.puts "Error: I'm not sure how to enable and disable system tests simultaneously"
exit 1
end
# OptionParser modifies ARGV, leaving the leftover arguments in ARGV # OptionParser modifies ARGV, leaving the leftover arguments in ARGV
if ARGV.empty? if ARGV.empty?
if !enable_system_tests && !disable_system_tests if !enable_system_tests
STDERR.puts "Not running system tests since it wasn't explicitly specified" STDERR.puts "Not running system tests since it wasn't explicitly specified"
end end
@ -95,9 +85,7 @@ if ARGV.empty?
use_runtime_info = true if use_runtime_info.nil? use_runtime_info = true if use_runtime_info.nil?
else else
if enable_system_tests || disable_system_tests STDERR.puts "Ignoring system test options since files were specified" if enable_system_tests
STDERR.puts "Ignoring system test options since files were specified"
end
files = ARGV files = ARGV
use_runtime_info = false if use_runtime_info.nil? use_runtime_info = false if use_runtime_info.nil?