From 3d59f767ae7c97a987dca9d165e2108b039dde89 Mon Sep 17 00:00:00 2001 From: Sam Date: Mon, 17 Oct 2022 10:13:34 +1100 Subject: [PATCH] FIX: remove RS384 and RS512 cose ciphers (#18619) RS256 was added for Windows Hello and as a side effect we speculatively added RS384 and RS512. These ciphers were not tested and are now failing on solo keys. It may be the case that the ciphers are not configured correctly on our side. It may be the case that this is a Solo key bug. Regardless, we are removing the ciphers and will only consider adding them again if absolutely needed. --- lib/freedom_patches/cose_rsapkcs1.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/freedom_patches/cose_rsapkcs1.rb b/lib/freedom_patches/cose_rsapkcs1.rb index d407260dc8a..f6964e1835f 100644 --- a/lib/freedom_patches/cose_rsapkcs1.rb +++ b/lib/freedom_patches/cose_rsapkcs1.rb @@ -44,7 +44,5 @@ module COSE end register(RSAPKCS1.new(-257, 'RS256', hash_function: 'SHA256')) - register(RSAPKCS1.new(-258, 'RS384', hash_function: 'SHA384')) - register(RSAPKCS1.new(-259, 'RS512', hash_function: 'SHA512')) end end