github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-30 15:28:37 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Use proper wording for contexts in specs

Browse Source
This commit is contained in:
Loïc Guitaut
2022-07-27 18:14:14 +02:00
committed by Loïc Guitaut
parent 02987e05d5
commit 3eaac56797
337 changed files with 2172 additions and 2723 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spec/requests/admin/reports_controller_spec.rb
View File

@ -14,7 +14,7 @@ RSpec.describe Admin::ReportsController do
end
describe '#bulk' do
context "valid params" do
context "with valid params" do
it "renders the reports as JSON" do
Fabricate(:topic)
get "/admin/reports/bulk.json", params: {
@ -29,8 +29,8 @@ RSpec.describe Admin::ReportsController do
end
end
context "invalid params" do
context "nonexistent report" do
context "with invalid params" do
context "with nonexistent report" do
it "returns not found reports" do
get "/admin/reports/bulk.json", params: {
reports: {
@ -46,7 +46,7 @@ RSpec.describe Admin::ReportsController do
end
end
context "invalid start or end dates" do
context "with invalid start or end dates" do
it "doesn't return 500 error" do
get "/admin/reports/bulk.json", params: {
reports: {
@ -67,7 +67,7 @@ RSpec.describe Admin::ReportsController do
end
describe '#show' do
context "invalid id form" do
context "with invalid id form" do
let(:invalid_id) { "!!&asdfasdf" }
it "returns 404" do
@ -76,15 +76,15 @@ RSpec.describe Admin::ReportsController do
end
end
context "valid type form" do
context 'missing report' do
context "with valid type form" do
context 'with missing report' do
it "returns a 404 error" do
get "/admin/reports/nonexistent.json"
expect(response.status).to eq(404)
end
end
context 'a report is found' do
context 'when a report is found' do
it "renders the report as JSON" do
Fabricate(:topic)
get "/admin/reports/topics.json"