github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-09 15:36:44 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Show warning only if new value is different (#12893)

Browse Source 
A warning is logged when a shadowed site setting is being changed. This
should not be the case when the new value is the same as the old one.
This commit is contained in:
Dan Ungureanu
2021-05-03 10:25:02 +03:00
committed by GitHub
parent 286b6916af
commit 3ff9dbb15c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/site_setting_extension.rb
View File

@ -484,7 +484,7 @@ module SiteSettingExtension
end end
define_singleton_method "#{clean_name}=" do |val| define_singleton_method "#{clean_name}=" do |val|
Rails.logger.warn("An attempt was to change #{clean_name} SiteSetting to #{val} however it is shadowed so this will be ignored!") Rails.logger.warn("An attempt was to change #{clean_name} SiteSetting to #{val} however it is shadowed so this will be ignored!") if value != val
nil nil
end end