github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-25 19:29:34 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: poll ranked choice voter expansion should append additional voters (#28432)

Browse Source 
Currently, for Ranked Choice results and voter list expansion, the code is replacing the voter list with the newly fetched page of voters instead of appending to the existing voter list. This is resolved in this PR and brings it in line with regular polls.

See: https://meta.discourse.org/t/ranked-choice-poll-does-not-reflect-change-of-votes-in-outcome/321227/18
This commit is contained in:
Robert
2024-11-05 01:28:32 +00:00
committed by GitHub
parent bba9a99e2e
commit 40a4d55c77
2 changed files with 27 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
plugins/poll/test/javascripts/acceptance/poll-results-test.js
View File

@ -979,14 +979,6 @@ acceptance("Poll results", function (needs) {
return helper.response({
voters: {
db753fe0bc4e72869ac1ad8765341764: [
{
id: 1,
username: "bianca",
name: null,
avatar_template:
"/letter_avatar_proxy/v4/letter/b/3be4f8/{size}.png",
title: null,
},
{
id: 7,
username: "foo",
@ -1004,16 +996,6 @@ acceptance("Poll results", function (needs) {
return helper.response({
voters: {
def034c6770c6fd3754c054ef9ec4721: [
{
rank: 1,
user: {
id: 1,
username: "bianca",
name: null,
avatar_template:
"/letter_avatar_proxy/v4/letter/b/3be4f8/{size}.png",
},
},
{
rank: 1,
user: {