Refactor requires login logic, reduce duplicate code

This also corrects the positioning in the chain of the check and removes misuse of prepend_before_action
2025-05-22 04:31:10 +08:00 · 2018-02-01 15:17:59 +11:00
parent ee0d3f15c1
commit 41986cdb2f
24 changed files with 57 additions and 26 deletions
--- a/app/controllers/topics_controller.rb
+++ b/app/controllers/topics_controller.rb
@ -6,7 +6,7 @@ require_dependency 'discourse_event'
 require_dependency 'rate_limiter'

 class TopicsController < ApplicationController
-  prepend_before_action :check_xhr, :ensure_logged_in, only: [
+  requires_login only: [
    :timings,
    :destroy_timings,
    :update,