github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-23 21:04:33 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: jquery removal/listeners/cleanup of permalink form (#14944)

Browse Source 
- Removes jquery
- Removes a not unregistered listener and uses component event
- Removes external-url class as it was only valid in one case of the dropdown
- Uses @action
- Tagless
- Other minor changes
This commit is contained in:
Joffrey JAFFEUX
2021-11-16 10:25:54 +01:00
committed by GitHub
parent c9a84d8067
commit 43659a6de2
2 changed files with 80 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

108
app/assets/javascripts/admin/addon/components/permalink-form.js
View File

@ -2,15 +2,18 @@ import Component from "@ember/component";
import I18n from "I18n";
import Permalink from "admin/models/permalink";
import bootbox from "bootbox";
import discourseComputed from "discourse-common/utils/decorators";
import discourseComputed, { bind } from "discourse-common/utils/decorators";
import { fmt } from "discourse/lib/computed";
import { schedule } from "@ember/runloop";
import { action } from "@ember/object";
export default Component.extend({
classNames: ["permalink-form"],
tagName: "",
formSubmitted: false,
permalinkType: "topic_id",
permalinkTypePlaceholder: fmt("permalinkType", "admin.permalink.%@"),
action: null,
permalinkTypeValue: null,
@discourseComputed
permalinkTypes() {
@ -23,70 +26,57 @@ export default Component.extend({
];
},
didInsertElement() {
this._super(...arguments);
schedule("afterRender", () => {
$(this.element.querySelector(".external-url")).keydown((e) => {
if (e.key === "Enter") {
this.send("submit");
}
});
});
},
@bind
focusPermalink() {
schedule("afterRender", () =>
this.element.querySelector(".permalink-url").focus()
this.element.querySelector(".permalink-url")?.focus()
);
},
actions: {
submit() {
if (!this.formSubmitted) {
this.set("formSubmitted", true);
@action
submitFormOnEnter(event) {
if (event.key === "Enter") {
this.onSubmit();
}
},
Permalink.create({
url: this.url,
permalink_type: this.permalinkType,
permalink_type_value: this.permalink_type_value,
})
.save()
.then(
(result) => {
this.setProperties({
url: "",
permalink_type_value: "",
formSubmitted: false,
@action
onSubmit() {
if (!this.formSubmitted) {
this.set("formSubmitted", true);
Permalink.create({
url: this.url,
permalink_type: this.permalinkType,
permalink_type_value: this.permalinkTypeValue,
})
.save()
.then(
(result) => {
this.setProperties({
url: "",
permalinkTypeValue: "",
formSubmitted: false,
});
this.action(Permalink.create(result.permalink));
this.focusPermalink();
},
(e) => {
this.set("formSubmitted", false);
let error;
if (e?.jqXHR?.responseJSON?.errors) {
error = I18n.t("generic_error_with_reason", {
error: e.jqXHR.responseJSON.errors.join(". "),
});
this.action(Permalink.create(result.permalink));
this.focusPermalink();
},
(e) => {
this.set("formSubmitted", false);
let error;
if (
e.jqXHR &&
e.jqXHR.responseJSON &&
e.jqXHR.responseJSON.errors
) {
error = I18n.t("generic_error_with_reason", {
error: e.jqXHR.responseJSON.errors.join(". "),
});
} else {
error = I18n.t("generic_error");
}
bootbox.alert(error, () => this.focusPermalink());
} else {
error = I18n.t("generic_error");
}
);
}
},
onChangePermalinkType(type) {
this.set("permalinkType", type);
},
bootbox.alert(error, this.focusPermalink);
}
);
}
},
});