github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-30 15:28:37 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: attempts to fix flakey drawer spec (#31749)

Browse Source 
The setup was happening after the page has loaded which could lead to
inconsistent results.
This commit is contained in:
Joffrey JAFFEUX
2025-03-11 14:57:35 +01:00
committed by GitHub
parent 14fe567bc6
commit 4433a72083
1 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
plugins/chat/spec/system/list_channels/drawer_spec.rb
View File

@ -127,16 +127,25 @@ RSpec.describe "List channels | Drawer", type: :system do
fab!(:dm_channel_4) { Fabricate(:direct_message_channel, users: [current_user, user_3]) }
it "sorts them by latest activity" do
Fabricate(
:chat_message,
chat_channel: dm_channel_2,
user: user_1,
use_service: true,
created_at: 2.days.ago,
)
Fabricate(
:chat_message,
chat_channel: dm_channel_4,
user: user_3,
use_service: true,
created_at: 1.days.ago,
)
dm_channel_4.membership_for(current_user).mark_read!
drawer_page.visit_index
drawer_page.click_direct_messages
Fabricate(:chat_message, chat_channel: dm_channel_2, user: user_1, use_service: true)
# last message was read but the created at date is used for sorting
message =
Fabricate(:chat_message, chat_channel: dm_channel_4, user: user_3, use_service: true)
dm_channel_4.membership_for(current_user).mark_read!(message.id)
try_until_success do
expect(drawer_page).to have_channel_at_position(dm_channel_2, 1)
expect(drawer_page).to have_urgent_channel(dm_channel_2)