github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-03 19:39:30 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Ensure browser network conditions is reset in system tests (#22404)

Browse Source 
Why this change?

By ensuring the reset happens in an `ensure` code block, we ensure that
the code will always be run even if code fails or an error is raised.
This helps to prevent leaking custom network condition states and
improves the stability of our system tests.
This commit is contained in:
Alan Guo Xiang Tan
2023-07-04 13:22:58 +08:00
committed by GitHub
parent 134dcdd63a
commit 454a4af0bf
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/chat/spec/system/chat_composer_spec.rb
View File

@ -142,7 +142,7 @@ RSpec.describe "Chat composer", type: :system do
expect(page).to have_css(".chat-composer-upload--in-progress")
expect(page).to have_css(".chat-composer.is-send-disabled")
ensure
page.driver.browser.network_conditions = { latency: 0 }
end
end